Continue emerging optimizer refactoring - #3737
Merged
Merged
Conversation
Contributor
|
/claude review |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
One critical bug found: the module will crash on import when emerging_optimizers is not installed, because SOAP is referenced unconditionally in the _EMERGING_OPTIMIZERS dict but is only defined inside the try block. See inline comment for details and suggested fixes.
skyw
force-pushed
the
eopt_refector_continued
branch
from
March 9, 2026 20:43
4ae0d5a to
0d30cb7
Compare
skyw
marked this pull request as ready for review
March 9, 2026 20:46
yaox12
approved these changes
Mar 10, 2026
Contributor
|
/ok to test 3a5d6fd |
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
skyw
force-pushed
the
eopt_refector_continued
branch
from
March 11, 2026 16:31
44e8755 to
e487e04
Compare
Contributor
Author
|
/ok to test e487e04 |
Signed-off-by: Hao Wu <skyw@nvidia.com>
Contributor
Author
|
/ok to test b8e0c56 |
Signed-off-by: Hao Wu <skyw@nvidia.com>
Contributor
Author
|
/ok to test 4b4c036 |
Signed-off-by: Hao Wu <skyw@nvidia.com>
Contributor
Author
|
/ok to test 8336473 |
Signed-off-by: Hao Wu <skyw@nvidia.com>
Contributor
Author
|
/ok to test dc7405f |
skyw
enabled auto-merge
March 11, 2026 22:02
chtruong814
approved these changes
Mar 12, 2026
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/22980964332 |
5 tasks
skyw
added a commit
to skyw/Megatron-LM
that referenced
this pull request
Apr 2, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Integrate emerging optimizer instead of muon alone.
Add soap support. other optimizers can come later.
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.