[Dev] Cherry-pick: M-FSDP: Cancel erroneous grad accumulation check (#3629) - #3729
Merged
Merged
Conversation
shjwudp
approved these changes
Mar 6, 2026
yaox12
approved these changes
Mar 6, 2026
yaox12
enabled auto-merge
March 6, 2026 02:42
Author
|
/ok to test 0eb36e3 |
Author
|
/ok to test 0eb36e3 |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/22753600664 |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/22755241911 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of #3629 from
mainintodev.gradient_accumulation_fusionin Megatron-FSDP. Since Transformer Engine v2.10, these features are compatible, so the restriction is no longer needed.Original PR: #3629
Original Author: @shjwudp
Made with Cursor