Skip to content

rename hybrid-cp to dynamic-cp and fix for rope when enabling THD + Dynamic-CP - #3717

Draft
xiaoyao0115 wants to merge 1 commit into
NVIDIA:mainfrom
xiaoyao0115:dynamic-cp-rename-and-fix-main
Draft

rename hybrid-cp to dynamic-cp and fix for rope when enabling THD + Dynamic-CP#3717
xiaoyao0115 wants to merge 1 commit into
NVIDIA:mainfrom
xiaoyao0115:dynamic-cp-rename-and-fix-main

Conversation

@xiaoyao0115

Copy link
Copy Markdown
Contributor

This PR mainly does two things:

  • Rename hybrid-cp to dynamic-cp for clarity.
  • Fix the THD + Dynamic-CP bug when using RoPE

PR for dev barnch: #3405

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

…amic-cp

Signed-off-by: tailaim <tailaim@nvidia.com>
@xiaoyao0115
xiaoyao0115 requested review from a team as code owners March 5, 2026 08:22
@copy-pr-bot

copy-pr-bot Bot commented Mar 5, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant