Skip to content

Support TP > GQA for inference - #3627

Merged
santhnm2 merged 2 commits into
NVIDIA:mainfrom
santhnm2:tp_gqa
Feb 26, 2026
Merged

Support TP > GQA for inference#3627
santhnm2 merged 2 commits into
NVIDIA:mainfrom
santhnm2:tp_gqa

Conversation

@santhnm2

Copy link
Copy Markdown
Contributor

What does this PR do ?

Fixes an issue in the KV cache allocation to support TP > GQA (clamps num_attention_heads_per_partition to 1).

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Feb 26, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@santhnm2
santhnm2 marked this pull request as ready for review February 26, 2026 16:41
@santhnm2
santhnm2 requested review from a team as code owners February 26, 2026 16:41
@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team February 26, 2026 16:41
@santhnm2

Copy link
Copy Markdown
Contributor Author

/ok to test 82ee43b

@santhnm2
santhnm2 enabled auto-merge February 26, 2026 17:58
@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Feb 26, 2026
@santhnm2
santhnm2 added this pull request to the merge queue Feb 26, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/22457413528

Merged via the queue into NVIDIA:main with commit afbce84 Feb 26, 2026
52 of 53 checks passed
@santhnm2
santhnm2 deleted the tp_gqa branch February 26, 2026 21:34
BoxiangW pushed a commit to BoxiangW/Megatron-LM that referenced this pull request Mar 4, 2026
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants