Skip to content

Use copy_signature to preserve typing of pass-through methods - #3419

Merged
yashaswikarnati merged 1 commit into
NVIDIA:mainfrom
nschank:copysig
Feb 24, 2026
Merged

Use copy_signature to preserve typing of pass-through methods#3419
yashaswikarnati merged 1 commit into
NVIDIA:mainfrom
nschank:copysig

Conversation

@nschank

@nschank nschank commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

Uses the copy_signature helper to propagate type hints through methods that simply pass arguments onward.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@nschank
nschank requested review from a team as code owners February 13, 2026 19:55
@copy-pr-bot

copy-pr-bot Bot commented Feb 13, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ko3n1g
ko3n1g requested a review from a team February 13, 2026 19:56
@chtruong814 chtruong814 added the needs-follow-up Issue needs follow-up label Feb 15, 2026
@Phlip79 Phlip79 added Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. complexity: low labels Feb 17, 2026
@Phlip79

Phlip79 commented Feb 17, 2026

Copy link
Copy Markdown
Member

/ok to test 9d75ec4

@chtruong814 chtruong814 added the needs-follow-up Issue needs follow-up label Feb 19, 2026
@yashaswikarnati

Copy link
Copy Markdown
Contributor

/ok to test 9e0a55f

@chtruong814 chtruong814 added the needs-follow-up Issue needs follow-up label Feb 21, 2026
@yashaswikarnati

Copy link
Copy Markdown
Contributor

/ok to test 9e0a55f

@yashaswikarnati
yashaswikarnati added this pull request to the merge queue Feb 24, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/22370905192

Merged via the queue into NVIDIA:main with commit 782e54b Feb 24, 2026
52 of 54 checks passed
@chtruong814 chtruong814 removed the needs-follow-up Issue needs follow-up label Feb 24, 2026
ko3n1g pushed a commit to ko3n1g/Megatron-LM that referenced this pull request Feb 26, 2026
BoxiangW pushed a commit to BoxiangW/Megatron-LM that referenced this pull request Mar 4, 2026
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-request complexity: low Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants