Skip to content

[dev] Add TE CUDA Graph Support for Vision Encoder for dev branch#3294

Open
tomlifu wants to merge 3 commits intoNVIDIA:devfrom
tomlifu:dev
Open

[dev] Add TE CUDA Graph Support for Vision Encoder for dev branch#3294
tomlifu wants to merge 3 commits intoNVIDIA:devfrom
tomlifu:dev

Conversation

@tomlifu
Copy link
Contributor

@tomlifu tomlifu commented Feb 6, 2026

What does this PR do ?

This PR adds TE CUDA Graph Support for Vision Encoder for dev branch.

Main branch mirror: #3293

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Signed-off-by: Lifu Zhang <lifuz@login-lyris02.lyris.clusters.nvidia.com>
@tomlifu tomlifu requested review from a team as code owners February 6, 2026 18:16
@copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 6, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: Lifu Zhang <lifuz@login-lyris01.lyris.clusters.nvidia.com>
@erhoo82 erhoo82 added module: multimodal Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. labels Feb 14, 2026
@tomlifu
Copy link
Contributor Author

tomlifu commented Feb 14, 2026

Hi, @tomlifu, we need to make new added Vision CUDA Graph can work with M4. You can refer to !3137, and test with

dist.use_decentralized_pg=True \
dist.use_gloo_process_groups=False \

We can test m4 after this PR is merged. If additional changes are needed, we should create a separate PR for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. module: multimodal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants