Skip to content

[dev] moe(feat): support chunkwise context parallelism for GDN. - #3282

Merged
yuzhongw-nvidia merged 9 commits into
NVIDIA:devfrom
yuzhongw-nvidia:yuzhongw/fla_cp
Jul 2, 2026
Merged

[dev] moe(feat): support chunkwise context parallelism for GDN.#3282
yuzhongw-nvidia merged 9 commits into
NVIDIA:devfrom
yuzhongw-nvidia:yuzhongw/fla_cp

Conversation

@yuzhongw-nvidia

@yuzhongw-nvidia yuzhongw-nvidia commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

PR for main: #6439

FLA gives another CP implementation for GDN fla-org/flash-linear-attention#691, which is claimed to outperform the old A2A-style CP. Integrate the new one into MCore.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@copy-pr-bot

copy-pr-bot Bot commented Feb 6, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yuzhongw-nvidia
yuzhongw-nvidia changed the base branch from main to dev February 6, 2026 09:57
@yuzhongw-nvidia
yuzhongw-nvidia force-pushed the yuzhongw/fla_cp branch 2 times, most recently from 5797148 to 94aed8b Compare April 22, 2026 08:55
@yuzhongw-nvidia yuzhongw-nvidia changed the title [dev] moe(feat): support FLA-style context parallelism for GDN. [dev] moe(feat): support AllGather context parallelism for GDN. May 5, 2026
@yuzhongw-nvidia
yuzhongw-nvidia force-pushed the yuzhongw/fla_cp branch 5 times, most recently from 4bb3983 to 0b476bd Compare June 12, 2026 08:33
@yuzhongw-nvidia
yuzhongw-nvidia marked this pull request as ready for review June 12, 2026 08:40
@yuzhongw-nvidia
yuzhongw-nvidia requested review from a team as code owners June 12, 2026 08:40
@yuzhongw-nvidia

Copy link
Copy Markdown
Contributor Author

/claude review

Comment thread tests/unit_tests/ssm/test_gated_delta_net.py Outdated
Comment thread tests/unit_tests/ssm/test_gated_delta_net.py

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — the all-gather CP integration and zigzag↔contiguous chunk reshuffling look correct. Left two comments about untested code paths (THD + all-gather CP, and batch > 1 + all-gather CP batch-folding) that may be worth covering or gating.

@yuzhongw-nvidia
yuzhongw-nvidia force-pushed the yuzhongw/fla_cp branch 3 times, most recently from a5ee414 to 7c4ca79 Compare June 16, 2026 07:47
@yuzhongw-nvidia yuzhongw-nvidia changed the title [dev] moe(feat): support AllGather context parallelism for GDN. [dev] moe(feat): support chunkwise context parallelism for GDN. Jun 16, 2026
@yuzhongw-nvidia
yuzhongw-nvidia force-pushed the yuzhongw/fla_cp branch 2 times, most recently from a4c2aaa to cbcf774 Compare June 16, 2026 10:15
yuzhongw-nvidia added a commit to yuzhongw-nvidia/Megatron-LM that referenced this pull request Jun 16, 2026
Squashed cherry-pick of refreshed PR NVIDIA#3282 at cbcf774.

Source commits:

- 85c00eb Add GDN context parallel communication modes

- cb11b0b Make GDN conv padding configurable

- bbf972c Reject batched SBHD all-gather CP in GDN

- 7c4ca79 Refactor GDN context parallel layout conversion

- cbcf774 Rename GDN linear CP modes

@Victarry Victarry left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!Thanks for the great work~

Signed-off-by: Yuzhong Wang <yuzhongw@nvidia.com>
Signed-off-by: Yuzhong Wang <yuzhongw@nvidia.com>
Signed-off-by: Yuzhong Wang <yuzhongw@nvidia.com>
Signed-off-by: Yuzhong Wang <yuzhongw@nvidia.com>
Signed-off-by: Yuzhong Wang <yuzhongw@nvidia.com>
Signed-off-by: Yuzhong Wang <yuzhongw@nvidia.com>
Signed-off-by: Yuzhong Wang <yuzhongw@nvidia.com>
Signed-off-by: Yuzhong Wang <yuzhongw@nvidia.com>
@yuzhongw-nvidia

Copy link
Copy Markdown
Contributor Author

/ok to test 6aaf4b7

Signed-off-by: Yuzhong Wang <yuzhongw@nvidia.com>
@yuzhongw-nvidia

Copy link
Copy Markdown
Contributor Author

/ok to test 0beec47

@xiaoyao0115 xiaoyao0115 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/28581864199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants