Repository navigation
Adithyare/sft ultra v3 feb2026 #3272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+582
−4
Closed
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
fa016fd
rebased main
arendu e039525
identity template and tool role mask
ae4717d
revert assert
44c5c24
Skip empty sequences and chunks in MTP tensor roll
rkarimimahab 8ed4905
add option for SFTTokenizer to build_tokenizers
arendu 30f1f32
resolve conflicts between args.sft and args.hybrid_context_parallel
arendu 72a2740
do not check for and add any EOD
arendu f82168a
removed dup identity template
arendu 68514e8
added from #2363
arendu d10fa92
use core sft_tokenizer
arendu edd864c
fmt
arendu 7bd7bfd
Merge remote-tracking branch 'github-upstream/main' into adithyare/sf…
arendu f71ad30
commit from main
arendu f3c6356
checkout main
arendu ee5e581
feat: update scripts for perf. optimizations such as HybridEP, Numact…
seonjinn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -80,6 +80,14 @@ def build_tokenizer(args, **kwargs): | |
| _set_padded_vocab_size(args, tokenizer) | ||
|
|
||
| return tokenizer | ||
| elif args.tokenizer_type == 'SFTTokenizer': | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How will this ever run with the case on line 66 present? |
||
| # SFTTokenizer uses the legacy tokenizer system | ||
| from megatron.core.tokenizers.text.libraries.sft_tokenizer import SFTTokenizer | ||
| tokenizer = SFTTokenizer( | ||
| args.tokenizer_model, | ||
| args.sft_tokenizer_prompt_format, | ||
| ) | ||
|
ananthsub marked this conversation as resolved.
Resolved
|
||
| return tokenizer | ||
|
|
||
| if args.tokenizer_metadata: | ||
| metadata = args.tokenizer_metadata | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.