Skip to content
Closed
Show file tree
Hide file tree
Changes from 13 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions megatron/core/tokenizers/text/libraries/sft_tokenizer.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@
# fmt: on


IGNORE_INDEX = -100
from megatron.core.datasets.megatron_tokenizer import MegatronLegacyTokenizer
from megatron.training.datasets.sft_dataset import IGNORE_INDEX
from megatron.training.tokenizer.multimodal_tokenizer import PromptConfig
Comment thread
arendu marked this conversation as resolved.
Resolved


@dataclass
Expand Down Expand Up @@ -154,7 +156,7 @@ def tokenize_conversation(
if turn["role"].lower() == "assistant" and len(turn["content"]) == 0:
raise ValueError(f"empty assistant turn in conversation: {conversation}.")
if turn["role"].lower() == "assistant":
assert conversation[turn_idx - 1]["role"].lower() in ("user", "tool")
assert conversation[turn_idx-1]["role"].lower() in ("user", "tool")

turn_tokens = self._tokenizer.apply_chat_template(
[turn], tokenize=True, chat_template=self._prompt_config.custom_chat_template
Expand Down
8 changes: 8 additions & 0 deletions megatron/core/tokenizers/utils/build_tokenizer.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,14 @@ def build_tokenizer(args, **kwargs):
_set_padded_vocab_size(args, tokenizer)

return tokenizer
elif args.tokenizer_type == 'SFTTokenizer':

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will this ever run with the case on line 66 present?

# SFTTokenizer uses the legacy tokenizer system
from megatron.core.tokenizers.text.libraries.sft_tokenizer import SFTTokenizer
tokenizer = SFTTokenizer(
args.tokenizer_model,
args.sft_tokenizer_prompt_format,
)
Comment thread
ananthsub marked this conversation as resolved.
Resolved
return tokenizer

if args.tokenizer_metadata:
metadata = args.tokenizer_metadata
Expand Down
4 changes: 0 additions & 4 deletions megatron/training/datasets/sft_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,10 +117,6 @@ def extend_with_padding(tokens, targets, positions, pad_len):
tokens_list = tokens.tolist()
targets_list = targets.tolist()

# Add EOD, unless it's already present
Comment thread
jaredcasper marked this conversation as resolved.
Resolved
if tokens_list[-1] != eod:
tokens_list.append(eod)
targets_list.append(eod)

pack_tokens.extend(tokens_list)
pack_targets.extend(targets_list)
Expand Down