Skip to content

Restore missing linear-cross-entropy option accidentally removed from arguments.py - #3266

Merged
yaox12 merged 2 commits into
NVIDIA:devfrom
shjwudp:entry_flag_for_linear_ce
Feb 6, 2026
Merged

Restore missing linear-cross-entropy option accidentally removed from arguments.py#3266
yaox12 merged 2 commits into
NVIDIA:devfrom
shjwudp:entry_flag_for_linear_ce

Conversation

@shjwudp

@shjwudp shjwudp commented Feb 5, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

Restore missing linear-cross-entropy option accidentally removed from arguments.py

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@shjwudp
shjwudp requested review from a team as code owners February 5, 2026 09:15
@shjwudp shjwudp added the dev branch Dev branch related issues and development label Feb 5, 2026
@copy-pr-bot

copy-pr-bot Bot commented Feb 5, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@shjwudp shjwudp added the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Feb 5, 2026
@yaox12
yaox12 enabled auto-merge February 5, 2026 09:31
@yaox12

yaox12 commented Feb 6, 2026

Copy link
Copy Markdown
Member

/ok to test 7ff5ba0

@ko3n1g ko3n1g added this to the Core 0.16 milestone Feb 6, 2026
@yaox12
yaox12 added this pull request to the merge queue Feb 6, 2026
Merged via the queue into NVIDIA:dev with commit ec94d63 Feb 6, 2026
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev branch Dev branch related issues and development Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants