Skip to content

Ensure type-checker understands use of Submodules in llava_model #3257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaox12 merged 3 commits into from
Feb 9, 2026
Merged

Ensure type-checker understands use of Submodules in llava_model #3257

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c23839a
Ensure type-checker understands use of Submodules in llava_model
nschank Jan 5, 2026
8bcc0b8
Fix line too long
nschank Feb 4, 2026
35920f8
Merge branch 'main' into llava
chtruong814 Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions megatron/core/models/multimodal/llava_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@
from megatron.core.packed_seq_params import PackedSeqParams
from megatron.core.process_groups_config import ProcessGroupCollection
from megatron.core.transformer import MegatronModule
from megatron.core.transformer.attention import SelfAttentionSubmodules
from megatron.core.transformer.spec_utils import ModuleSpec
from megatron.core.transformer.transformer_config import TransformerConfig
from megatron.core.transformer.transformer_layer import TransformerLayerSubmodules
from megatron.core.utils import deprecate_inference_params, log_single_rank

try:
Expand Down Expand Up @@ -158,9 +160,18 @@ def __init__(
self.context_parallel_lm = language_transformer_config.context_parallel_size
if self.sequence_parallel_lm or self.context_parallel_lm > 1:
if not language_model_type.startswith('nemotron5-hybrid'):
attn_module = language_transformer_layer_spec.submodules.self_attention
assert isinstance(
language_transformer_layer_spec.submodules, TransformerLayerSubmodules
)
assert isinstance(
language_transformer_layer_spec.submodules.self_attention.submodules,
SelfAttentionSubmodules,
)
attn_submodules = (
language_transformer_layer_spec.submodules.self_attention.submodules
)
assert (
attn_module.submodules.core_attention == TEDotProductAttention and HAVE_TE
attn_submodules.core_attention == TEDotProductAttention and HAVE_TE
), "Sequence/Context Parallelism is supported only with TE DotProductAttention."
if self.context_parallel_lm > 1:
self.cp_group = self.pg_collection.cp
Expand Down
Loading