Skip to content

Ensure type-checker understands use of Submodules in bert_model - #3256

Merged
yashaswikarnati merged 3 commits into
NVIDIA:mainfrom
nschank:bert
Feb 6, 2026
Merged

Ensure type-checker understands use of Submodules in bert_model#3256
yashaswikarnati merged 3 commits into
NVIDIA:mainfrom
nschank:bert

Conversation

@nschank

@nschank nschank commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

In order to safely refactor Submodules classes, I want to make sure I can easily find everywhere those classes are being referenced. This updates bert_model to appropriately type-check the submodules its introspecting into, which ensures the type-checker (and things like Find References in VSCode) will understand the usage of these objects below.

Relevant design doc: Typed ModuleSpec.pdf

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@nschank
nschank requested review from a team as code owners February 4, 2026 20:29
@copy-pr-bot

copy-pr-bot Bot commented Feb 4, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@nschank

nschank commented Feb 4, 2026

Copy link
Copy Markdown
Contributor Author

Split out from #2834

@ko3n1g
ko3n1g requested a review from a team February 4, 2026 20:30
@yashaswikarnati yashaswikarnati added Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. Final Review PR is in the "final review" stage labels Feb 4, 2026
@yashaswikarnati

Copy link
Copy Markdown
Contributor

/ok to test f7b5a85

@ko3n1g

ko3n1g commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

I had to update your branch to fix an issue with the CI.

@ko3n1g

ko3n1g commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

/ok to test 380e103

@yashaswikarnati

Copy link
Copy Markdown
Contributor

/ok to test 48e914f

@yashaswikarnati
yashaswikarnati added this pull request to the merge queue Feb 6, 2026
Merged via the queue into NVIDIA:main with commit cfbe9b5 Feb 6, 2026
70 of 74 checks passed
@nschank
nschank deleted the bert branch February 13, 2026 19:51
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
…IA#3256)

Co-authored-by: oliver könig <okoenig@nvidia.com>
Co-authored-by: Yashaswi Karnati <144376261+yashaswikarnati@users.noreply.github.com>
BoxiangW pushed a commit to BoxiangW/Megatron-LM that referenced this pull request Mar 4, 2026
…IA#3256)

Co-authored-by: oliver könig <okoenig@nvidia.com>
Co-authored-by: Yashaswi Karnati <144376261+yashaswikarnati@users.noreply.github.com>
ko3n1g added a commit to ko3n1g/Megatron-LM that referenced this pull request Mar 31, 2026
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
…IA#3256)

Co-authored-by: oliver könig <okoenig@nvidia.com>
Co-authored-by: Yashaswi Karnati <144376261+yashaswikarnati@users.noreply.github.com>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
…IA#3256)

Co-authored-by: oliver könig <okoenig@nvidia.com>
Co-authored-by: Yashaswi Karnati <144376261+yashaswikarnati@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-request Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. Final Review PR is in the "final review" stage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants