Skip to content

Fix missing PackedSeqParams import - #3214

Merged
parthmannan merged 5 commits into
NVIDIA:mainfrom
parthmannan:pmannan/hcp_fix
Feb 3, 2026
Merged

Fix missing PackedSeqParams import#3214
parthmannan merged 5 commits into
NVIDIA:mainfrom
parthmannan:pmannan/hcp_fix

Conversation

@parthmannan

Copy link
Copy Markdown
Contributor

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@parthmannan
parthmannan requested review from a team as code owners February 3, 2026 01:47
@copy-pr-bot

copy-pr-bot Bot commented Feb 3, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ko3n1g
ko3n1g requested a review from a team February 3, 2026 01:47
@ericharper

Copy link
Copy Markdown
Contributor

We need more testing for packed sequences.

@parthmannan

Copy link
Copy Markdown
Contributor Author

/ok to test 6e3bb75

@ko3n1g ko3n1g added this to the Core 0.16 milestone Feb 3, 2026
@parthmannan parthmannan added the core_r0.16.0 Cherry-pick label for core_r0.16.0 release branch label Feb 3, 2026
@parthmannan
parthmannan enabled auto-merge February 3, 2026 20:00
@parthmannan

Copy link
Copy Markdown
Contributor Author

/ok to test bcc5374

@parthmannan

Copy link
Copy Markdown
Contributor Author

/ok to test 59d41f1

@parthmannan
parthmannan added this pull request to the merge queue Feb 3, 2026
Merged via the queue into NVIDIA:main with commit bc2eb9a Feb 3, 2026
45 checks passed
@parthmannan
parthmannan deleted the pmannan/hcp_fix branch February 3, 2026 23:34
ko3n1g pushed a commit that referenced this pull request Feb 3, 2026
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
parthmannan added a commit to parthmannan/Megatron-LM that referenced this pull request Feb 4, 2026
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core_r0.16.0 Cherry-pick label for core_r0.16.0 release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants