Skip to content

Reapply "Add MTP support for hybrid models (#2363)" - #3207

Merged
ko3n1g merged 6 commits into
NVIDIA:mainfrom
sancha:sasatheesh/mtp-reapply
Feb 4, 2026
Merged

Reapply "Add MTP support for hybrid models (#2363)"#3207
ko3n1g merged 6 commits into
NVIDIA:mainfrom
sancha:sasatheesh/mtp-reapply

Conversation

@sancha

@sancha sancha commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@sancha
sancha requested review from a team as code owners February 2, 2026 18:37
@copy-pr-bot

copy-pr-bot Bot commented Feb 2, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ko3n1g
ko3n1g requested a review from a team February 2, 2026 18:37
@sancha

sancha commented Feb 2, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test fc2a93c

@sancha

sancha commented Feb 3, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 3857c44

@sancha

sancha commented Feb 4, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 876ca47

@dimapihtar dimapihtar added complexity: high Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. labels Feb 4, 2026
@sancha

sancha commented Feb 4, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 52f27ba

@ko3n1g ko3n1g left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-merge the reapply

@ko3n1g
ko3n1g merged commit 9d71cb1 into NVIDIA:main Feb 4, 2026
44 of 46 checks passed
@deepakn94 deepakn94 mentioned this pull request Feb 5, 2026
6 tasks
yfw pushed a commit to yaoyu-33/Megatron-LM that referenced this pull request Feb 23, 2026
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
@sancha
sancha deleted the sasatheesh/mtp-reapply branch February 27, 2026 01:18
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: high Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants