Skip to content

Fix seq pack flag in get_logprobs #3206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mathemakitten merged 2 commits into from
Feb 3, 2026
+1 −1
Merged

Fix seq pack flag in get_logprobs #3206

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
949f210
Fix seq pack flag in get_logprobs
mathemakitten Feb 2, 2026
bcaf121
Merge branch 'main' into helenn-fix-training-cudagraphs-feb2026
mathemakitten Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion megatron/rl/rl_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1003,7 +1003,7 @@ def logprobs_forward_step(data_iterator, model, is_correction, packing_context=N
b_trajs.cuda(),
b_posids.cuda(),
no_grad=True,
sequence_packing=b_packed_seq_params is not None,
sequence_packing=packing_context is not None,
packed_seq_params=b_packed_seq_params,
),
None,
Expand Down
Loading