cp: Fix: nccl-ub in ddp path (3181) into main - #3182
Merged
Conversation
youngeunkwon0405
approved these changes
Jan 30, 2026
Member
|
/ok to test 410714e |
yaoyu-33
approved these changes
Jan 30, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3182 +/- ##
==========================================
- Coverage 68.73% 68.72% -0.01%
==========================================
Files 339 339
Lines 44712 44719 +7
==========================================
+ Hits 30733 30734 +1
- Misses 13979 13985 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jaredcasper
approved these changes
Jan 31, 2026
youngeunkwon0405
enabled auto-merge
January 31, 2026 04:43
daiyaanarfeen
pushed a commit
to daiyaanarfeen/Megatron-LM
that referenced
this pull request
Feb 23, 2026
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com> Co-authored-by: Youngeun Kwon <youngeunk@nvidia.com>
yangbofun
pushed a commit
to xlm-research/Megatron-LM
that referenced
this pull request
May 22, 2026
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com> Co-authored-by: Youngeun Kwon <youngeunk@nvidia.com>
terminator123
pushed a commit
to 021ai/Megatron-LM
that referenced
this pull request
Aug 3, 2026
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com> Co-authored-by: Youngeun Kwon <youngeunk@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[🤖]: Hi @youngeunkwon0405 👋
We've cherry-picked
Fix: nccl-ub in ddp path (#3181)intomainfor you! 🚀Please review and approve this cherry-pick at your convenience!