Skip to content

[Dev] Fix EP Overlap Bugs for Full-Iter CG - #3163

Merged
Wohox merged 11 commits into
NVIDIA:devfrom
Wohox:pingtian/fix_1f1b_overlap_bug_with_full_iter_cg
Feb 4, 2026
Merged

[Dev] Fix EP Overlap Bugs for Full-Iter CG#3163
Wohox merged 11 commits into
NVIDIA:devfrom
Wohox:pingtian/fix_1f1b_overlap_bug_with_full_iter_cg

Conversation

@Wohox

@Wohox Wohox commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

Fix following bugs for full-iter cg:

  • Missing stream context for backward dw.
  • Memory leak when using HybridEP+FP8.
  • Missing record stream for HybridEP's tokens_per_expert.
  • Accidentally release the input memory of grouped gemm.

PR for main: #3164

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@copy-pr-bot

copy-pr-bot Bot commented Jan 30, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Wohox
Wohox requested a review from lhb8125 January 30, 2026 04:13
@Wohox
Wohox requested a review from BestJuly January 30, 2026 04:18
@Wohox
Wohox marked this pull request as ready for review February 2, 2026 07:08
@Wohox
Wohox requested review from a team as code owners February 2, 2026 07:08
Comment thread megatron/core/models/gpt/fine_grained_callables.py Outdated
Comment thread megatron/core/pipeline_parallel/utils.py
@Wohox Wohox changed the title (draft)[Dev] Fix EP Overlap Bugs for Full-Iter CG [Dev] Fix EP Overlap Bugs for Full-Iter CG Feb 2, 2026
@Wohox Wohox added dev branch Dev branch related issues and development bug Something isn't working labels Feb 2, 2026
@Wohox

Wohox commented Feb 3, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test e04d2ce

@Wohox

Wohox commented Feb 4, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 8b6ada8

@Wohox

Wohox commented Feb 4, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test f862dee

@Wohox
Wohox enabled auto-merge February 4, 2026 03:16
@Wohox Wohox added the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Feb 4, 2026
@Wohox
Wohox added this pull request to the merge queue Feb 4, 2026
Merged via the queue into NVIDIA:dev with commit fa5bcf6 Feb 4, 2026
44 of 46 checks passed
@Wohox
Wohox deleted the pingtian/fix_1f1b_overlap_bug_with_full_iter_cg branch February 4, 2026 05:06
@Wohox Wohox mentioned this pull request Feb 10, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dev branch Dev branch related issues and development Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants