Skip to content

Cherrypick CI improvements to dev branch #3118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ko3n1g merged 2 commits into from
Jan 29, 2026
Merged

Cherrypick CI improvements to dev branch #3118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31e0a20
ci: Repeat func tests, save logs of unit tests and lessen debug outpu…
ko3n1g Jan 27, 2026
90bd650
Merge remote-tracking branch 'github/dev' into ko3n1g/ci/healthiness-dev
ko3n1g Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/actions/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,14 +149,17 @@ runs:
ARGS=(
--scope mr-github
--enable-lightweight-mode
--n-repeat 1
)
elif [ "${{ steps.has-run-functional-tests-label.outputs.main }}" == "true" ]; then
ARGS=(
--scope mr-github
--n-repeat 5
)
else
ARGS=(
--scope mr-github-slim
--n-repeat 5
)
fi

Expand Down Expand Up @@ -258,5 +261,5 @@ runs:
if: always()
with:
name: ${{ steps.check.outputs.logs_report }}
path: ${{ inputs.is_unit_test == 'true' && 'logs' || 'assets_dir' }}
path: ${{ inputs.is_unit_test == 'true' && 'assets_dir/logs' || 'assets_dir' }}
include-hidden-files: true
8 changes: 7 additions & 1 deletion tests/test_utils/python_scripts/launch_nemo_run_workload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ def is_flaky_failure(concat_allranks_logs: str) -> bool:
@click.option("--environment", required=True, type=str, help="Environment of the workload")
@click.option("--platform", required=True, type=str, help="Platform of the workload")
@click.option("--container-image", required=True, type=str, help="Container image of the workload")
@click.option(
"--n-repeat", required=False, type=int, help="Number of times to repeat the workload", default=1
)
@click.option("--data-dir", required=False, type=str, help="Data directory of the workload")
@click.option("--tag", required=False, type=str, help="Tag of the workload")
@click.option(
Expand All @@ -68,6 +71,7 @@ def main(
environment,
platform,
container_image,
n_repeat: int = 1,
data_dir: Optional[str] = None,
tag: Optional[str] = None,
enable_lightweight_mode: Optional[bool] = False,
Expand All @@ -92,6 +96,7 @@ def main(
magic_values["assets_dir"] = "/opt/megatron-lm/assets_dir"
magic_values["artifacts_dir"] = "/opt/megatron-lm/artifacts_dir"
magic_values["environment"] = environment
magic_values["n_repeat"] = n_repeat
magic_values["test_case"] = workload.spec["test_case"]
magic_values["name"] = workload.spec["name"].format(**magic_values)
workload.spec["script"] = workload.spec["script"].format(**magic_values)
Expand All @@ -113,9 +118,10 @@ def main(
"PYTHONUNBUFFERED": "1",
"OUTPUT_PATH": os.getcwd(),
"ENABLE_LIGHTWEIGHT_MODE": str(enable_lightweight_mode).lower(),
"N_REPEAT": "1",
"N_REPEAT": str(n_repeat),
"CLUSTER": "dgxh100_dgxc",
"NCCL_DEBUG": "INFO",
"NCCL_DEBUG_FILE": "/opt/megatron-lm/assets_dir/logs/nccl_debug.log",
},
packager=run.Packager(),
volumes=artifacts,
Expand Down
Loading