Skip to content

mRoPE for MTP #3114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaox12 merged 2 commits into from
Feb 2, 2026
Merged

mRoPE for MTP #3114

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53a9915
mrope for mtp
BestJuly Jan 28, 2026
cea23f4
Merge branch 'main' into lit/mrope_for_mtp
maanug-nv Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions megatron/training/arguments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1221,9 +1221,11 @@ def validate_args(args, defaults={}):

if args.mtp_num_layers:
assert not args.use_legacy_models, "The legacy Megatron models does not support Multi-Token Prediction (MTP)."
assert args.position_embedding_type == "rope" or args.position_embedding_type == "none", (
f"Multi-Token Prediction (MTP) is not supported with {args.position_embedding_type} position embedding type."
+ f"The supported position embedding types are rope and none."
# MTP is compatible with position embedding types that use position_ids.
supported_position_types = ["learned_absolute", "rope", "mrope", "none"]
assert args.position_embedding_type in supported_position_types, (
f"Multi-Token Prediction (MTP) is not supported with '{args.position_embedding_type}' position embedding type. "
f"The supported position embedding types are: {', '.join(supported_position_types)}."
)

if args.cpu_offloading_num_layers > 0:
Expand Down
Loading