Skip to content

Fix TE 2.12 AllGather CI failure - #3101

Merged
yanring merged 4 commits into
NVIDIA:mainfrom
BestJuly:lit/fix_ci_0127
Feb 3, 2026
Merged

Fix TE 2.12 AllGather CI failure#3101
yanring merged 4 commits into
NVIDIA:mainfrom
BestJuly:lit/fix_ci_0127

Conversation

@BestJuly

@BestJuly BestJuly commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

Fix CI failures when bumping to TE 2.12.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@Phlip79 Phlip79 added Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. complexity: low labels Feb 2, 2026
Comment thread megatron/core/transformer/moe/token_dispatcher.py
@deepakn94

Copy link
Copy Markdown
Contributor

Do we need a TransformerEngine version guard for this change?

@yaox12

yaox12 commented Feb 3, 2026

Copy link
Copy Markdown
Member

Do we need a TransformerEngine version guard for this change?

No. The triton kernel actually requires an int, but previously we were passing a scalar tensor to it by mistake. It worked with some previous Triton versions but caused an error with the latest Triton. Passing an int should always be correct.

@yanring
yanring enabled auto-merge February 3, 2026 02:57
@yanring

yanring commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

/ok to test 7859d3b

@yaox12 yaox12 added Final Review PR is in the "final review" stage and removed Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. labels Feb 3, 2026
@deepakn94
deepakn94 removed the request for review from a team February 3, 2026 06:05
@yanring
yanring added this pull request to the merge queue Feb 3, 2026
Merged via the queue into NVIDIA:main with commit 1a61b77 Feb 3, 2026
47 of 49 checks passed
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
Co-authored-by: Jared Casper <155158+jaredcasper@users.noreply.github.com>
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
Co-authored-by: Jared Casper <155158+jaredcasper@users.noreply.github.com>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Co-authored-by: Jared Casper <155158+jaredcasper@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: low Final Review PR is in the "final review" stage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants