Skip to content

Bug fix with --no-use-tokenizer-from-checkpoint-args - #3049

Merged
jon-barker merged 4 commits into
NVIDIA:mainfrom
jon-barker:jbarker/no_tokenizer_from_ckpt_fix
Jan 23, 2026
Merged

Bug fix with --no-use-tokenizer-from-checkpoint-args#3049
jon-barker merged 4 commits into
NVIDIA:mainfrom
jon-barker:jbarker/no_tokenizer_from_ckpt_fix

Conversation

@jon-barker

Copy link
Copy Markdown
Contributor

What does this PR do ?

When using --use-checkpoint-args and --no-use-tokenizer-from-checkpoint-args we are still forcing that args.tokenizer_type gets set from the checkpoint. We have internal checkpoints where this causes a failure since the checkpoint args tokenizer_type is incorrect.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@jon-barker jon-barker self-assigned this Jan 22, 2026
@copy-pr-bot

copy-pr-bot Bot commented Jan 22, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ko3n1g
ko3n1g requested a review from a team January 22, 2026 20:08
@jon-barker
jon-barker requested a review from deepakn94 January 22, 2026 20:08
@jon-barker jon-barker added the Final Review PR is in the "final review" stage label Jan 22, 2026
@jon-barker
jon-barker enabled auto-merge January 23, 2026 16:46
@jon-barker

Copy link
Copy Markdown
Contributor Author

/ok to test a4c3d12

@ko3n1g ko3n1g added this to the Core 0.16 milestone Jan 23, 2026
@jon-barker
jon-barker added this pull request to the merge queue Jan 23, 2026
Merged via the queue into NVIDIA:main with commit 029f48f Jan 23, 2026
48 checks passed
@jon-barker
jon-barker deleted the jbarker/no_tokenizer_from_ckpt_fix branch January 23, 2026 17:46
github-merge-queue Bot pushed a commit that referenced this pull request Jan 23, 2026
…#3057)

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
Co-authored-by: Jon Barker <jbarker@oci-hsg-cs-001-vscode-01.cm.cluster>
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
Co-authored-by: Jon Barker <jbarker@oci-hsg-cs-001-vscode-01.cm.cluster>
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
…3049)" (NVIDIA#3057)

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Co-authored-by: Jon Barker <jbarker@oci-hsg-cs-001-vscode-01.cm.cluster>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Final Review PR is in the "final review" stage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants