Add ability to save wgrads and dgrads - #3032
Merged
deepakn94 merged 5 commits intoJan 24, 2026
Merged
Conversation
erhoo82
approved these changes
Jan 22, 2026
kvareddy
approved these changes
Jan 22, 2026
jaredcasper
approved these changes
Jan 22, 2026
deepakn94
force-pushed
the
dnarayanan/wgrad_and_dgrad_logging
branch
from
January 22, 2026 20:22
81c75aa to
45a6dcf
Compare
deepakn94
force-pushed
the
dnarayanan/wgrad_and_dgrad_logging
branch
from
January 23, 2026 19:43
9b8da33 to
2ff9e5a
Compare
deepakn94
enabled auto-merge
January 23, 2026 19:45
deepakn94
force-pushed
the
dnarayanan/wgrad_and_dgrad_logging
branch
from
January 23, 2026 21:46
2ff9e5a to
fb63246
Compare
… code wgrad saving requires that the DP collective is an all-reduce instead of reduce-scatter to make it easier to pull wgrads from DP replica 0. Some other gotchas: - First gradient reduction (when metadata is being collected about when to launch collectives) should also be an all-reduce if needed - start_grad_sync call should be a no-op if in first batch and collective has already been dispatched - Don't try calling reduce_scatter_with_fp32_accumulation's .wait() method if using all-reduce in a particular iteration Signed-off-by: Deepak Narayanan <dnarayanan@nvidia.com>
Signed-off-by: Deepak Narayanan <dnarayanan@nvidia.com>
Signed-off-by: Deepak Narayanan <dnarayanan@nvidia.com>
Signed-off-by: Deepak Narayanan <dnarayanan@nvidia.com>
deepakn94
force-pushed
the
dnarayanan/wgrad_and_dgrad_logging
branch
from
January 24, 2026 04:01
fb63246 to
1dfb8b5
Compare
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 24, 2026
Signed-off-by: Deepak Narayanan <dnarayanan@nvidia.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jan 24, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 24, 2026
Signed-off-by: Deepak Narayanan <dnarayanan@nvidia.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wgrad saving requires that the DP collective is an all-reduce instead of reduce-scatter to make it easier to pull wgrads from DP replica 0. Some other gotchas: