fix ep weight gradnorm/num_zero calculation error for muon - #3024
Merged
Conversation
Contributor
Author
|
/ok to test d1cf84f |
Contributor
Author
|
/ok to test b6f763b |
Contributor
Author
|
/ok to test f14b678 |
Contributor
Author
|
/ok to test e605a76 |
Contributor
Author
|
/ok to test 1ec5636 |
skyw
approved these changes
Jan 22, 2026
skyw
left a comment
Contributor
There was a problem hiding this comment.
muon change LGTM.
Test cases change need to be reviewed by folks familiar with the manner.
ko3n1g
approved these changes
Jan 22, 2026
jaredcasper
approved these changes
Jan 22, 2026
BoxiangW
approved these changes
Jan 22, 2026
Contributor
|
/ok to test 1ec5636 |
FDecaYed
enabled auto-merge
January 26, 2026 04:00
ericharper
approved these changes
Jan 26, 2026
Contributor
|
/ok to test 1ec5636 |
FDecaYed
disabled auto-merge
January 26, 2026 05:39
FDecaYed
enabled auto-merge
January 26, 2026 05:40
daiyaanarfeen
pushed a commit
to daiyaanarfeen/Megatron-LM
that referenced
this pull request
Feb 23, 2026
yangbofun
pushed a commit
to xlm-research/Megatron-LM
that referenced
this pull request
May 22, 2026
terminator123
pushed a commit
to 021ai/Megatron-LM
that referenced
this pull request
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
With muon, expert weight are no longer belong to a separate optimizer instance and thus chainedoptimizer gradnorm/zero calculation was wrong reducing among EP ranks. This PR separate expert weights out into separate muon instance to fix that.
The issue causes dp rank weight diverge and was caught with checkpoint loading test. turn the broken test back on
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.