Skip to content

fix ep weight gradnorm/num_zero calculation error for muon - #3024

Merged
FDecaYed merged 8 commits into
NVIDIA:mainfrom
FDecaYed:deyuf/fix_muon_ep
Jan 26, 2026
Merged

fix ep weight gradnorm/num_zero calculation error for muon#3024
FDecaYed merged 8 commits into
NVIDIA:mainfrom
FDecaYed:deyuf/fix_muon_ep

Conversation

@FDecaYed

Copy link
Copy Markdown
Contributor

What does this PR do ?

With muon, expert weight are no longer belong to a separate optimizer instance and thus chainedoptimizer gradnorm/zero calculation was wrong reducing among EP ranks. This PR separate expert weights out into separate muon instance to fix that.
The issue causes dp rank weight diverge and was caught with checkpoint loading test. turn the broken test back on

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@FDecaYed
FDecaYed requested review from a team as code owners January 21, 2026 06:53
@copy-pr-bot

copy-pr-bot Bot commented Jan 21, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ko3n1g
ko3n1g requested a review from a team January 21, 2026 06:53
@FDecaYed

Copy link
Copy Markdown
Contributor Author

/ok to test d1cf84f

@FDecaYed

Copy link
Copy Markdown
Contributor Author

/ok to test b6f763b

@FDecaYed

Copy link
Copy Markdown
Contributor Author

/ok to test f14b678

@FDecaYed

Copy link
Copy Markdown
Contributor Author

/ok to test e605a76

@FDecaYed

Copy link
Copy Markdown
Contributor Author

/ok to test 1ec5636

@skyw skyw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

muon change LGTM.
Test cases change need to be reviewed by folks familiar with the manner.

@ko3n1g ko3n1g added the Final Review PR is in the "final review" stage label Jan 22, 2026
@BoxiangW

Copy link
Copy Markdown
Contributor

/ok to test 1ec5636

@FDecaYed
FDecaYed enabled auto-merge January 26, 2026 04:00
@BoxiangW
BoxiangW requested a review from ericharper January 26, 2026 04:06
@BoxiangW

Copy link
Copy Markdown
Contributor

/ok to test 1ec5636

@FDecaYed
FDecaYed disabled auto-merge January 26, 2026 05:39
@FDecaYed
FDecaYed enabled auto-merge January 26, 2026 05:40
@FDecaYed
FDecaYed added this pull request to the merge queue Jan 26, 2026
Merged via the queue into NVIDIA:main with commit b2e9390 Jan 26, 2026
120 of 126 checks passed
@FDecaYed
FDecaYed deleted the deyuf/fix_muon_ep branch January 26, 2026 05:45
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Final Review PR is in the "final review" stage Run functional tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants