Skip to content

[Refactor] Decouple topk and loss from DSA Indexer - #3013

Merged
yanring merged 6 commits into
NVIDIA:devfrom
meituan-search:dsa_refactor
Feb 4, 2026
Merged

[Refactor] Decouple topk and loss from DSA Indexer#3013
yanring merged 6 commits into
NVIDIA:devfrom
meituan-search:dsa_refactor

Conversation

@laixinn

@laixinn laixinn commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

After this refactor, DSA is compatible with the upcoming fused kernel.

PR for main #3248

Unit Test

  • tests/unit_tests/transformer/test_attention_variant_dsa.py

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@laixinn
laixinn requested review from a team and pablo-garay as code owners January 20, 2026 12:52
@copy-pr-bot

copy-pr-bot Bot commented Jan 20, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ko3n1g
ko3n1g requested a review from a team January 20, 2026 12:53
@laixinn
laixinn changed the base branch from main to dev January 20, 2026 13:05
@laixinn
laixinn requested a review from a team as a code owner January 20, 2026 13:05

@duncanriach duncanriach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All clear for hybrid-mamba

@chtruong814 chtruong814 added the needs-follow-up Issue needs follow-up label Jan 22, 2026
@kunlunl kunlunl mentioned this pull request Jan 29, 2026
@chtruong814 chtruong814 removed the needs-follow-up Issue needs follow-up label Jan 30, 2026
@kunlunl

kunlunl commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

/ok to test a857d6a

@kunlunl

kunlunl commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

/ok to test 5f6769e

@kunlunl

kunlunl commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

/ok to test d3adddf

@yanring
yanring added this pull request to the merge queue Feb 4, 2026
Merged via the queue into NVIDIA:dev with commit a592819 Feb 4, 2026
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants