Fix several syntax error - #3004
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes three Python syntax errors that would prevent the code from compiling:
- An f-string syntax error caused by unmatched quotes in nested dictionary access
- Multiple instances of using
isoperator with string literals instead of== - An invalid escape sequence in a regex pattern string
Changes:
- Fixed f-string syntax by changing double quotes to single quotes inside f-string interpolations
- Replaced
isoperator with==for string literal comparisons in three locations - Added raw string prefix
rto regex pattern to properly handle escape sequences
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tests/test_utils/python_scripts/launch_nemo_run_workload.py | Fixed f-string syntax error by using single quotes for dictionary key access within f-string interpolations |
| megatron/legacy/model/vision/esvit_swin_backbone.py | Replaced three instances of is '*' with == '*' to properly compare string values |
| examples/multimodal/evaluation/evaluate_mmmu.py | Added raw string prefix to regex pattern to fix invalid escape sequence error |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HollowMan6
force-pushed
the
syntax_errors
branch
from
January 19, 2026 22:52
edc23f3 to
a2b2d98
Compare
*** Error compiling './Megatron-LM/examples/multimodal/evaluation/evaluate_mmmu.py'...
File "./Megatron-LM/examples/multimodal/evaluation/evaluate_mmmu.py", line 107
m = re.search("'Overall': {'num': \d+, 'acc': (\d.\d+)}", output.stdout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: invalid escape sequence '\d'
*** Error compiling './Megatron-LM/megatron/legacy/model/vision/esvit_swin_backbone.py'...
File "./Megatron-LM/megatron/legacy/model/vision/esvit_swin_backbone.py", line 729
or pretrained_layers[0] is '*'
^^^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: "is" with a literal. Did you mean "=="?
*** Error compiling './Megatron-LM/tests/test_utils/python_scripts/launch_nemo_run_workload.py'...
File "./Megatron-LM/tests/test_utils/python_scripts/launch_nemo_run_workload.py", line 137
logger.info(f"Job succeeded with status: {job_dict["status"]}")
^^^^^^
SyntaxError: f-string: unmatched '['
Signed-off-by: Hollow Man <hollowman@opensuse.org>
HollowMan6
force-pushed
the
syntax_errors
branch
from
January 23, 2026 13:55
a2b2d98 to
582a9cc
Compare
Contributor
|
/ok to test 72eb942 |
Signed-off-by: Hollow Man <hollowman@opensuse.org>
Contributor
Author
|
Added the copyright header, CI should all pass now. cc: @dimapihtar |
yaox12
enabled auto-merge
February 2, 2026 06:29
Member
|
/ok to test 3b6c2f7 |
daiyaanarfeen
pushed a commit
to daiyaanarfeen/Megatron-LM
that referenced
this pull request
Feb 23, 2026
Signed-off-by: Hollow Man <hollowman@opensuse.org> Co-authored-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com> Co-authored-by: Xin Yao <xiny@nvidia.com>
yangbofun
pushed a commit
to xlm-research/Megatron-LM
that referenced
this pull request
May 22, 2026
Signed-off-by: Hollow Man <hollowman@opensuse.org> Co-authored-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com> Co-authored-by: Xin Yao <xiny@nvidia.com>
terminator123
pushed a commit
to 021ai/Megatron-LM
that referenced
this pull request
Aug 3, 2026
Signed-off-by: Hollow Man <hollowman@opensuse.org> Co-authored-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com> Co-authored-by: Xin Yao <xiny@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
*** Error compiling './Megatron-LM/examples/multimodal/evaluation/evaluate_mmmu.py'...
File "./Megatron-LM/examples/multimodal/evaluation/evaluate_mmmu.py", line 107
m = re.search("'Overall': {'num': \d+, 'acc': (\d.\d+)}", output.stdout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: invalid escape sequence '\d'
*** Error compiling './Megatron-LM/megatron/legacy/model/vision/esvit_swin_backbone.py'...
File "./Megatron-LM/megatron/legacy/model/vision/esvit_swin_backbone.py", line 729
or pretrained_layers[0] is '*'
^^^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: "is" with a literal. Did you mean "=="?
*** Error compiling './Megatron-LM/tests/test_utils/python_scripts/launch_nemo_run_workload.py'...
File "./Megatron-LM/tests/test_utils/python_scripts/launch_nemo_run_workload.py", line 137
logger.info(f"Job succeeded with status: {job_dict["status"]}")
^^^^^^
SyntaxError: f-string: unmatched '['
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.