Skip to content

Fix several syntax error - #3004

Merged
yaox12 merged 4 commits into
NVIDIA:mainfrom
HollowMan6:syntax_errors
Feb 2, 2026
Merged

Fix several syntax error#3004
yaox12 merged 4 commits into
NVIDIA:mainfrom
HollowMan6:syntax_errors

Conversation

@HollowMan6

Copy link
Copy Markdown
Contributor

What does this PR do ?

*** Error compiling './Megatron-LM/examples/multimodal/evaluation/evaluate_mmmu.py'...
File "./Megatron-LM/examples/multimodal/evaluation/evaluate_mmmu.py", line 107
m = re.search("'Overall': {'num': \d+, 'acc': (\d.\d+)}", output.stdout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: invalid escape sequence '\d'

*** Error compiling './Megatron-LM/megatron/legacy/model/vision/esvit_swin_backbone.py'...
File "./Megatron-LM/megatron/legacy/model/vision/esvit_swin_backbone.py", line 729
or pretrained_layers[0] is '*'
^^^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: "is" with a literal. Did you mean "=="?

*** Error compiling './Megatron-LM/tests/test_utils/python_scripts/launch_nemo_run_workload.py'...
File "./Megatron-LM/tests/test_utils/python_scripts/launch_nemo_run_workload.py", line 137
logger.info(f"Job succeeded with status: {job_dict["status"]}")
^^^^^^
SyntaxError: f-string: unmatched '['

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Copilot AI review requested due to automatic review settings January 19, 2026 22:34
@copy-pr-bot

copy-pr-bot Bot commented Jan 19, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes three Python syntax errors that would prevent the code from compiling:

  1. An f-string syntax error caused by unmatched quotes in nested dictionary access
  2. Multiple instances of using is operator with string literals instead of ==
  3. An invalid escape sequence in a regex pattern string

Changes:

  • Fixed f-string syntax by changing double quotes to single quotes inside f-string interpolations
  • Replaced is operator with == for string literal comparisons in three locations
  • Added raw string prefix r to regex pattern to properly handle escape sequences

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
tests/test_utils/python_scripts/launch_nemo_run_workload.py Fixed f-string syntax error by using single quotes for dictionary key access within f-string interpolations
megatron/legacy/model/vision/esvit_swin_backbone.py Replaced three instances of is '*' with == '*' to properly compare string values
examples/multimodal/evaluation/evaluate_mmmu.py Added raw string prefix to regex pattern to fix invalid escape sequence error

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread megatron/legacy/model/vision/esvit_swin_backbone.py
Comment thread examples/multimodal/evaluation/evaluate_mmmu.py Outdated
Comment thread examples/multimodal/evaluation/evaluate_mmmu.py Outdated
Comment thread megatron/legacy/model/vision/esvit_swin_backbone.py
@chtruong814 chtruong814 added the needs-follow-up Issue needs follow-up label Jan 21, 2026
*** Error compiling './Megatron-LM/examples/multimodal/evaluation/evaluate_mmmu.py'...
  File "./Megatron-LM/examples/multimodal/evaluation/evaluate_mmmu.py", line 107
    m = re.search("'Overall': {'num': \d+, 'acc': (\d.\d+)}", output.stdout)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: invalid escape sequence '\d'

*** Error compiling './Megatron-LM/megatron/legacy/model/vision/esvit_swin_backbone.py'...
  File "./Megatron-LM/megatron/legacy/model/vision/esvit_swin_backbone.py", line 729
    or pretrained_layers[0] is '*'
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: "is" with a literal. Did you mean "=="?

*** Error compiling './Megatron-LM/tests/test_utils/python_scripts/launch_nemo_run_workload.py'...
  File "./Megatron-LM/tests/test_utils/python_scripts/launch_nemo_run_workload.py", line 137
    logger.info(f"Job succeeded with status: {job_dict["status"]}")
                                                        ^^^^^^
SyntaxError: f-string: unmatched '['

Signed-off-by: Hollow Man <hollowman@opensuse.org>

@dimapihtar dimapihtar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@dimapihtar

Copy link
Copy Markdown
Contributor

/ok to test 72eb942

Signed-off-by: Hollow Man <hollowman@opensuse.org>
@HollowMan6

Copy link
Copy Markdown
Contributor Author

Added the copyright header, CI should all pass now.

cc: @dimapihtar

@chtruong814 chtruong814 added the needs-follow-up Issue needs follow-up label Jan 31, 2026
@yaox12
yaox12 enabled auto-merge February 2, 2026 06:29
@yaox12

yaox12 commented Feb 2, 2026

Copy link
Copy Markdown
Member

/ok to test 3b6c2f7

@yaox12
yaox12 added this pull request to the merge queue Feb 2, 2026
Merged via the queue into NVIDIA:main with commit dff4189 Feb 2, 2026
45 checks passed
@HollowMan6
HollowMan6 deleted the syntax_errors branch February 2, 2026 13:31
@chtruong814 chtruong814 removed the needs-follow-up Issue needs follow-up label Feb 2, 2026
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
Signed-off-by: Hollow Man <hollowman@opensuse.org>
Co-authored-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
Signed-off-by: Hollow Man <hollowman@opensuse.org>
Co-authored-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Signed-off-by: Hollow Man <hollowman@opensuse.org>
Co-authored-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants