Skip to content

[Dev] recover FusedMLP API - #2978

Closed
HaochenYuan wants to merge 2 commits into
NVIDIA:devfrom
HaochenYuan:recover_FusedMLP_API
Closed

[Dev] recover FusedMLP API#2978
HaochenYuan wants to merge 2 commits into
NVIDIA:devfrom
HaochenYuan:recover_FusedMLP_API

Conversation

@HaochenYuan

Copy link
Copy Markdown
Contributor

What does this PR do ?

Previous modification breaks FusedMLP API and may cause error in modelopt. This PR makes some refactor.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@HaochenYuan
HaochenYuan requested review from a team as code owners January 16, 2026 09:38
@ko3n1g ko3n1g added this to the Core 0.16 milestone Jan 16, 2026
@HaochenYuan HaochenYuan added module: moe dev branch Dev branch related issues and development labels Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev branch Dev branch related issues and development module: moe Run functional tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants