Skip to content

ci(fix): GB200 racecondition - #2962

Merged
ko3n1g merged 2 commits into
NVIDIA:devfrom
ko3n1g:ko3n1g/ci/fix-gb200-racecondition
Jan 15, 2026
Merged

ci(fix): GB200 racecondition#2962
ko3n1g merged 2 commits into
NVIDIA:devfrom
ko3n1g:ko3n1g/ci/fix-gb200-racecondition

Conversation

@ko3n1g

@ko3n1g ko3n1g commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

We're repeating tests 5 times. each loop is:

  • delete old logs;
  • training (that generates logs)
  • evaluate logs;

Since GB testing happens on two nodes, one of the node was now finishing the evaluation faster than the other one. the faster node already deleted logs as part of the next loop before the slower node started evaluating

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g
ko3n1g enabled auto-merge January 15, 2026 15:41
@ko3n1g
ko3n1g disabled auto-merge January 15, 2026 15:42
@ko3n1g
ko3n1g merged commit a32b198 into NVIDIA:dev Jan 15, 2026
49 checks passed
ko3n1g added a commit that referenced this pull request Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants