Skip to content

Optimizing post-processing of requests - #2920

Merged
sidsingh-nvidia merged 36 commits into
NVIDIA:mainfrom
sidsingh-nvidia:siddharth/optimize-post-proc
Jan 24, 2026
Merged

Optimizing post-processing of requests#2920
sidsingh-nvidia merged 36 commits into
NVIDIA:mainfrom
sidsingh-nvidia:siddharth/optimize-post-proc

Conversation

@sidsingh-nvidia

Copy link
Copy Markdown
Contributor

What does this PR do ?

  1. Optimizes serialization logic for finished requests
  2. Overlaps detokenization with the engine step.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@sidsingh-nvidia sidsingh-nvidia self-assigned this Jan 13, 2026
@sidsingh-nvidia sidsingh-nvidia added module: inference Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. labels Jan 13, 2026

@Phlip79 Phlip79 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a parameterized test or similar for self.use_coordinator.

Comment thread megatron/core/inference/inference_request.py Outdated
Comment thread megatron/core/inference/inference_request.py Outdated
Comment thread megatron/core/inference/inference_request.py
Comment thread megatron/core/inference/inference_request.py Outdated
Comment thread megatron/core/inference/inference_request.py
Comment thread megatron/core/inference/data_parallel_inference_coordinator.py
Comment thread megatron/core/inference/inference_request.py
Comment thread megatron/core/inference/inference_request.py
@siddharth9820

Copy link
Copy Markdown

@Phlip79 we have functional tests in the suite for both values of the self.use_coordinator boolean.

@tdene tdene mentioned this pull request Jan 21, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants