Skip to content

Fix RL sequence packing bin size - #2909

Merged
tdene merged 4 commits into
NVIDIA:mainfrom
tdene:tde/rl_seq_pack_bin_size
Jan 12, 2026
Merged

Fix RL sequence packing bin size#2909
tdene merged 4 commits into
NVIDIA:mainfrom
tdene:tde/rl_seq_pack_bin_size

Conversation

@tdene

@tdene tdene commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

The argument --rl-sequence-packing-max-sequences-per-bin was changed from its default of 50 to 32 because empirical testing showed a speed-up in iteration time.

The value of this argument determines how many no-ops the cu_seqlen tensor that gets fed into TE's RoPE kernels may be padded with. Unfortunately, such no-ops still take execution time, slowing down the overall iteration. Reducing the total number of ops from 50 to 32 speeds up iteration.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@jalbericiola jalbericiola left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread megatron/training/arguments.py
@tdene
tdene added this pull request to the merge queue Jan 12, 2026
Merged via the queue into NVIDIA:main with commit ce2cc40 Jan 12, 2026
48 checks passed
@tdene
tdene deleted the tde/rl_seq_pack_bin_size branch January 12, 2026 21:46
copy-pr-bot Bot pushed a commit that referenced this pull request Jan 12, 2026
copy-pr-bot Bot pushed a commit that referenced this pull request Jan 13, 2026
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants