Skip to content

Add unit test for LatentMoE - #2892

Merged
yaox12 merged 8 commits into
NVIDIA:mainfrom
venmugil:velango/latent_moe_unit_test
Feb 3, 2026
Merged

Add unit test for LatentMoE#2892
yaox12 merged 8 commits into
NVIDIA:mainfrom
venmugil:velango/latent_moe_unit_test

Conversation

@venmugil

@venmugil venmugil commented Jan 9, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@copy-pr-bot

copy-pr-bot Bot commented Jan 9, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@deepakn94

Copy link
Copy Markdown
Contributor

/ok to test 7aa1021

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution!

NVIDIA Megatron-LM is currently transitioning to development on Github. We will aim to review your PR after we complete our transition and stabilize our Github development process.

Thank you for your understanding.

auto-merge was automatically disabled January 17, 2026 00:55

Head branch was pushed to by a user without write access

@venmugil

Copy link
Copy Markdown
Contributor Author

/ok to test b411228

@venmugil

Copy link
Copy Markdown
Contributor Author

/ok to test caf463b

@yaox12
yaox12 enabled auto-merge February 2, 2026 06:33
@yaox12

yaox12 commented Feb 2, 2026

Copy link
Copy Markdown
Member

/ok to test 183dcbf

auto-merge was automatically disabled February 2, 2026 22:42

Head branch was pushed to by a user without write access

@venmugil

venmugil commented Feb 2, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test ac18ac7

@yaox12
yaox12 enabled auto-merge February 3, 2026 01:57
@yaox12

yaox12 commented Feb 3, 2026

Copy link
Copy Markdown
Member

/ok to test 2271dcf

@yaox12
yaox12 added this pull request to the merge queue Feb 3, 2026
Merged via the queue into NVIDIA:main with commit 7080697 Feb 3, 2026
45 checks passed
@chtruong814 chtruong814 removed the needs-follow-up Issue needs follow-up label Feb 3, 2026
@venmugil
venmugil deleted the velango/latent_moe_unit_test branch February 3, 2026 15:54
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
Co-authored-by: Xin Yao <xiny@nvidia.com>
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
Co-authored-by: Xin Yao <xiny@nvidia.com>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Co-authored-by: Xin Yao <xiny@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants