Skip to content

Update type hints and doc strings for moe_utils.py - #2821

Merged
yaox12 merged 6 commits into
NVIDIA:mainfrom
JavaZeroo:patch-3
Jan 23, 2026
Merged

Update type hints and doc strings for moe_utils.py#2821
yaox12 merged 6 commits into
NVIDIA:mainfrom
JavaZeroo:patch-3

Conversation

@JavaZeroo

@JavaZeroo JavaZeroo commented Jan 6, 2026

Copy link
Copy Markdown
Contributor

Added type hints for logits and z_loss_coeff in z_loss_func.

@yaox12 Update type hints and doc strings for moe_utils.py

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @megatron-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @megatron-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Added type hints for logits and z_loss_coeff in z_loss_func.
@JavaZeroo
JavaZeroo requested review from a team as code owners January 6, 2026 03:41
@copy-pr-bot

copy-pr-bot Bot commented Jan 6, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yaox12 yaox12 added the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Jan 9, 2026
@yaox12 yaox12 added Final Review PR is in the "final review" stage and removed Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. labels Jan 9, 2026
@chtruong814 chtruong814 added the needs-follow-up Issue needs follow-up label Jan 11, 2026
Comment thread megatron/core/transformer/moe/moe_utils.py Outdated
yaox12 and others added 3 commits January 15, 2026 09:35
@yaox12 yaox12 changed the title Add type hints to z_loss_func parameters Update type hints and doc strings for moe_utils.py Jan 15, 2026
@yaox12
yaox12 requested a review from Skylion007 January 15, 2026 02:47
@yaox12

yaox12 commented Jan 15, 2026

Copy link
Copy Markdown
Member

/ok to test b1d74ae

@chtruong814 chtruong814 added needs-follow-up Issue needs follow-up and removed needs-follow-up Issue needs follow-up labels Jan 16, 2026
@yaox12

yaox12 commented Jan 19, 2026

Copy link
Copy Markdown
Member

/ok to test 2747a95

@chtruong814 chtruong814 removed the needs-follow-up Issue needs follow-up label Jan 21, 2026
@yaox12
yaox12 enabled auto-merge January 22, 2026 03:21
@yaox12

This comment was marked as spam.

@copy-pr-bot

This comment was marked as outdated.

@yaox12

yaox12 commented Jan 22, 2026

Copy link
Copy Markdown
Member

/ok to test 9e66cd3

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution!

NVIDIA Megatron-LM is currently transitioning to development on Github. We will aim to review your PR after we complete our transition and stabilize our Github development process.

Thank you for your understanding.

@yaox12
yaox12 added this pull request to the merge queue Jan 22, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jan 22, 2026
@yaox12
yaox12 added this pull request to the merge queue Jan 23, 2026
Merged via the queue into NVIDIA:main with commit 03e0915 Jan 23, 2026
46 of 48 checks passed
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
Co-authored-by: Xin Yao <yaox12@outlook.com>
Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
Co-authored-by: Xin Yao <yaox12@outlook.com>
Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Co-authored-by: Xin Yao <yaox12@outlook.com>
Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-request Final Review PR is in the "final review" stage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants