feat: add routing replay for Mcore#2693
Conversation
yanring
left a comment
There was a problem hiding this comment.
Thanks for the great PR👍. I've left a few comments.
I am very honored to receive your reply and suggestions. I will follow your advice to modify the code. |
|
/ok to test 1a1793d |
@yanring, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/ |
|
/ok to test 745cb8f |
Head branch was pushed to by a user without write access
|
/ok to test dbc0158 |
|
Thank you for your contribution! NVIDIA Megatron-LM is currently transitioning to development on Github. We will aim to review your PR after we complete our transition and stabilize our Github development process. Thank you for your understanding. |
What does this PR do ?
This PR introduces a "Router Replay" feature for Mixture-of-Experts (MoE) layers. This functionality provides a deterministic routing mechanism, which is essential for debugging, controlled experimentation, and reproducing model behavior.
Inspired by recent approaches in stabilizing MoE models Router Replay(R2) and Rollout Router Replay(R3),
RouterReplayimplementation allows developers to easily save and set the router's replay information, providing precise control over the expert selection process to mitigate routing inconsistencieImplementation Details:
RouterReplay, is introduced inmoe_utils.pyto manage the state and data for the replay functionality.TopKRouter:topk_routing_with_score_functionduring the routing process.topk_routing_with_score_functionhas been updated to handle the router_replay object.Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.