Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions megatron/core/models/gpt/fine_grained_callables.py
Original file line number Diff line number Diff line change
Expand Up @@ -170,11 +170,16 @@ def forward_impl(self, hidden_states):

Returns:
The logits or loss depending on whether labels are provided.

Note:
Final layernorm now has been moved from the post-process stage to the
last decoder layer, so we don't need to run the final layer norm here.
"""

empty_decoder = len(self.gpt_model.decoder.layers) == 0
layer_norm = self.gpt_model.decoder.final_layernorm
if not self.gpt_model.config.mtp_num_layers and empty_decoder and layer_norm:
hidden_states = layer_norm(hidden_states)
hidden_states = make_viewless_tensor(
inp=hidden_states, requires_grad=True, keep_graph=True
)

# Run GPTModel._postprocess
loss = self.gpt_model._postprocess(
hidden_states=hidden_states,
Expand Down
Loading