Prep work for migrating to types from ModuleSpec - #2668
Merged
Conversation
6 tasks
yashaswikarnati
approved these changes
Dec 17, 2025
Contributor
|
/ok to test c2ec6bc |
Contributor
|
/ok to test ab36a98 |
ericharper
approved these changes
Dec 19, 2025
jaredcasper
approved these changes
Dec 23, 2025
yashaswikarnati
enabled auto-merge
December 23, 2025 21:00
Contributor
|
/ok to test d12cce0 |
auto-merge was automatically disabled
December 24, 2025 19:10
Head branch was pushed to by a user without write access
Contributor
|
/ok to test dd191b4 |
Contributor
|
Thank you for your contribution! NVIDIA Megatron-LM is currently transitioning to development on Github. We will aim to review your PR after we complete our transition and stabilize our Github development process. Thank you for your understanding. |
yashaswikarnati
enabled auto-merge
December 24, 2025 19:13
jon-barker
pushed a commit
to jon-barker/Megatron-LM
that referenced
this pull request
Jan 9, 2026
maanug-nv
pushed a commit
to maanug-nv/Megatron-LM
that referenced
this pull request
Jan 10, 2026
maanug-nv
pushed a commit
to maanug-nv/Megatron-LM
that referenced
this pull request
Jan 20, 2026
daiyaanarfeen
pushed a commit
to daiyaanarfeen/Megatron-LM
that referenced
this pull request
Feb 23, 2026
yangbofun
pushed a commit
to xlm-research/Megatron-LM
that referenced
this pull request
May 22, 2026
terminator123
pushed a commit
to 021ai/Megatron-LM
that referenced
this pull request
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Non-intrusive updates to make ModuleSpec migrations easier.
Associated design doc:
Typed ModuleSpec.pdf
These changes are ancillary and unblock other migrations as mentioned in the doc.
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.