Skip to content

Prep work for migrating to types from ModuleSpec - #2668

Merged
yashaswikarnati merged 6 commits into
NVIDIA:mainfrom
nschank:modspec1
Dec 24, 2025
Merged

Prep work for migrating to types from ModuleSpec#2668
yashaswikarnati merged 6 commits into
NVIDIA:mainfrom
nschank:modspec1

Conversation

@nschank

@nschank nschank commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

What does this PR do ?

Non-intrusive updates to make ModuleSpec migrations easier.

Associated design doc:
Typed ModuleSpec.pdf

These changes are ancillary and unblock other migrations as mentioned in the doc.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@nschank
nschank requested review from a team as code owners December 15, 2025 22:45
@copy-pr-bot

copy-pr-bot Bot commented Dec 15, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yashaswikarnati

Copy link
Copy Markdown
Contributor

/ok to test c2ec6bc

@yashaswikarnati

Copy link
Copy Markdown
Contributor

/ok to test ab36a98

@yashaswikarnati

Copy link
Copy Markdown
Contributor

/ok to test d12cce0

auto-merge was automatically disabled December 24, 2025 19:10

Head branch was pushed to by a user without write access

@yashaswikarnati

Copy link
Copy Markdown
Contributor

/ok to test dd191b4

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution!

NVIDIA Megatron-LM is currently transitioning to development on Github. We will aim to review your PR after we complete our transition and stabilize our Github development process.

Thank you for your understanding.

@yashaswikarnati
yashaswikarnati added this pull request to the merge queue Dec 24, 2025
Merged via the queue into NVIDIA:main with commit dd7c9f4 Dec 24, 2025
47 checks passed
@nschank
nschank deleted the modspec1 branch December 24, 2025 21:59
jon-barker pushed a commit to jon-barker/Megatron-LM that referenced this pull request Jan 9, 2026
maanug-nv pushed a commit to maanug-nv/Megatron-LM that referenced this pull request Jan 10, 2026
maanug-nv pushed a commit to maanug-nv/Megatron-LM that referenced this pull request Jan 20, 2026
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants