Skip to content

[DEV][NVFP4][MOE] 128 Zero Padding for Grouped Quantization kernels and Cuda Graph Support - #2654

Merged
yaox12 merged 5 commits into
NVIDIA:devfrom
zhongbozhu:dev_nvfp4_128_padding
Jan 9, 2026
Merged

[DEV][NVFP4][MOE] 128 Zero Padding for Grouped Quantization kernels and Cuda Graph Support #2654
yaox12 merged 5 commits into
NVIDIA:devfrom
zhongbozhu:dev_nvfp4_128_padding

Conversation

@zhongbozhu

@zhongbozhu zhongbozhu commented Dec 13, 2025

Copy link
Copy Markdown
Contributor

What does this PR do ?

Bump up zero padding size for NVFP4 MOE training to 128.

Mcore PR to MAIN: #2655

TE PR: NVIDIA/TransformerEngine#2411

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share discuss a design-doc with the team.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@zhongbozhu
zhongbozhu requested review from a team as code owners December 13, 2025 00:11
@copy-pr-bot

copy-pr-bot Bot commented Dec 13, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yaox12
yaox12 enabled auto-merge December 15, 2025 02:49
@yaox12

yaox12 commented Dec 15, 2025

Copy link
Copy Markdown
Member

/ok to test b53c03e

@yaox12

yaox12 commented Jan 4, 2026

Copy link
Copy Markdown
Member

/ok to test 448e736

Signed-off-by: Zhongbo Zhu <zhongboz@nvidia.com>
Signed-off-by: Zhongbo Zhu <zhongboz@nvidia.com>
Signed-off-by: Zhongbo Zhu <zhongboz@nvidia.com>
Signed-off-by: Zhongbo Zhu <zhongboz@nvidia.com>
@zhongbozhu
zhongbozhu force-pushed the dev_nvfp4_128_padding branch from 448e736 to e6f55cb Compare January 7, 2026 00:46
@yanring

yanring commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

/ok to test e6f55cb

@yaox12

yaox12 commented Jan 9, 2026

Copy link
Copy Markdown
Member

/ok to test 328986d

@yaox12
yaox12 added this pull request to the merge queue Jan 9, 2026
Merged via the queue into NVIDIA:dev with commit ed6ebff Jan 9, 2026
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants