Skip to content

[Dev] Fix CUDA RNG Tracker#2640

Merged
yaox12 merged 9 commits intoNVIDIA:devfrom
buptzyb:robinz/dev_fix_rng
Dec 17, 2025
Merged

[Dev] Fix CUDA RNG Tracker#2640
yaox12 merged 9 commits intoNVIDIA:devfrom
buptzyb:robinz/dev_fix_rng

Conversation

@buptzyb
Copy link
Copy Markdown
Contributor

@buptzyb buptzyb commented Dec 12, 2025

What does this PR do ?

Main PR #2641

  1. Let RandomSTE use expert-parallel-rng instead of a private generator.
  2. No matter saved checkpoint in normal rng or graphable rng format, loading to either format is allowed, with the newly added convert_cuda_rng_state() function.
  3. Fix a bug that _get_all_rng_states() get tracker rng in graphable format, but the default cuda rng in normal format. Now we make them return in the same format. Same for _set_all_rng_states().
  4. Fix a bug in nested fork with non-graphble rng - always use the latest state.
  5. Capture graphs in rng context - same as how it works in TransformerBlock.
  6. Add related unit tests.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share discuss a design-doc with the team.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Signed-off-by: Robin Zhang <robinz@nvidia.com>
@buptzyb buptzyb requested review from a team as code owners December 12, 2025 04:07
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Dec 12, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@buptzyb buptzyb self-assigned this Dec 12, 2025
@buptzyb
Copy link
Copy Markdown
Contributor Author

buptzyb commented Dec 12, 2025

/ok to test 8fabd33

@ko3n1g ko3n1g added this to the Core 0.16 milestone Dec 12, 2025
@buptzyb buptzyb requested a review from Victarry December 12, 2025 04:08
@buptzyb buptzyb added Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. core_dev_r0.15.0 dev branch Dev branch related issues and development labels Dec 12, 2025
Signed-off-by: Robin Zhang <robinz@nvidia.com>
@buptzyb
Copy link
Copy Markdown
Contributor Author

buptzyb commented Dec 12, 2025

/ok to test 4811190

Signed-off-by: Robin Zhang <robinz@nvidia.com>
Signed-off-by: Robin Zhang <robinz@nvidia.com>
@yanring yanring requested a review from HaochenYuan December 13, 2025 03:17
Signed-off-by: Robin Zhang <robinz@nvidia.com>
@buptzyb buptzyb added the Final Review PR is in the "final review" stage label Dec 16, 2025
@buptzyb
Copy link
Copy Markdown
Contributor Author

buptzyb commented Dec 16, 2025

/ok to test 2b80450

@yaox12 yaox12 enabled auto-merge December 17, 2025 04:01
Signed-off-by: Robin Zhang <robinz@nvidia.com>
@buptzyb
Copy link
Copy Markdown
Contributor Author

buptzyb commented Dec 17, 2025

/ok to test fb303e3

@yaox12 yaox12 added this pull request to the merge queue Dec 17, 2025
Merged via the queue into NVIDIA:dev with commit 2ebff67 Dec 17, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev branch Dev branch related issues and development Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. Final Review PR is in the "final review" stage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants