Skip to content

[Dev] Feat(moe): Gated delta net context parallel (CP) - #2614

Merged
Victarry merged 3 commits into
NVIDIA:devfrom
yuzhongw-nvidia:qwen3next_cp
Dec 19, 2025
Merged

[Dev] Feat(moe): Gated delta net context parallel (CP)#2614
Victarry merged 3 commits into
NVIDIA:devfrom
yuzhongw-nvidia:qwen3next_cp

Conversation

@yuzhongw-nvidia

@yuzhongw-nvidia yuzhongw-nvidia commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

What does this PR do ?

Support context parallel (CP) for Gated delta net (GDN) towards long context training for Qwen3-next series.

MR for main

Methodology

Gated Delta Net (GDN) follows Mamba context parallelization scheme, which adopts all-to-all communication to convert the context parallel for the computation of attention.

Specifically, q, k, v, gate, beta, alpha are initially distributed along the sequence dimension (shape: [s / CP, b, head, ...]). We use all-to-all communication to convert it to head-parallel (shape: [s, b, head / CP, ...]). Then, we can compute the attention parallelly on each CP rank, which has the full sequence but only partial heads. Finally, we use all-to-all communication to convert it back to context-parallel (shape: [s / CP, b, head, ...]).

Usage

Using argument --context-parallel-size.

Convergence

image image

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@copy-pr-bot

copy-pr-bot Bot commented Dec 10, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yuzhongw-nvidia

Copy link
Copy Markdown
Contributor Author

/ok to test 8844935

@yuzhongw-nvidia

Copy link
Copy Markdown
Contributor Author

/ok to test 72616c5

@yuzhongw-nvidia

Copy link
Copy Markdown
Contributor Author

/ok to test 10f6ab4

@yuzhongw-nvidia

Copy link
Copy Markdown
Contributor Author

/ok to test c22d2c3

@Victarry
Victarry added this pull request to the merge queue Dec 19, 2025
Merged via the queue into NVIDIA:dev with commit a935008 Dec 19, 2025
43 of 45 checks passed
yuzhongw-nvidia added a commit to yuzhongw-nvidia/Megatron-LM that referenced this pull request Mar 24, 2026
…NVIDIA#3040, NVIDIA#3220)

- Add context parallel (CP) support to GatedDeltaNet via all-to-all
  communication (tensor_a2a_cp2hp / tensor_a2a_hp2cp)
- Refine GDN implementation: replace causal_conv1d_fn with fla.modules.convolution,
  extract _prepare_qkv_for_gated_delta_rule and _compute_g_and_beta as @jit_fuser methods
- Update TransformerConfig to remove CP==1 assertion for gated_delta_net
  and add linear_attention_type deprecation alias
- Enable CP test cases in test_gated_delta_net.py and refactor correctness
  test to use shared _test_parallel_attention_correctness helper

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yuzhongw-nvidia added a commit to yuzhongw-nvidia/Megatron-LM that referenced this pull request Mar 24, 2026
yuzhongw-nvidia added a commit to yuzhongw-nvidia/Megatron-LM that referenced this pull request Mar 24, 2026
yuzhongw-nvidia added a commit to yuzhongw-nvidia/Megatron-LM that referenced this pull request Mar 24, 2026
yuzhongw-nvidia added a commit to yuzhongw-nvidia/Megatron-LM that referenced this pull request Apr 7, 2026
yuzhongw-nvidia added a commit to yuzhongw-nvidia/Megatron-LM that referenced this pull request Apr 10, 2026
yuzhongw-nvidia added a commit to yuzhongw-nvidia/Megatron-LM that referenced this pull request Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants