Various CUDA graph improvements on capture time, replay time, memory footprint - #2572
Merged
ericharper merged 43 commits intoJan 22, 2026
Merged
Conversation
jiemingz
force-pushed
the
jiemingz/mcore_cudagraph_improvements
branch
from
December 8, 2025 04:09
0cf9ab8 to
2b8f924
Compare
jiemingz
force-pushed
the
jiemingz/mcore_cudagraph_improvements
branch
from
December 8, 2025 14:14
d86d6db to
9f268c1
Compare
jiemingz
force-pushed
the
jiemingz/mcore_cudagraph_improvements
branch
from
December 16, 2025 16:52
9f268c1 to
8b0fe08
Compare
Contributor
|
Can we throw an error or at least a warning if |
jiemingz
force-pushed
the
jiemingz/mcore_cudagraph_improvements
branch
3 times, most recently
from
December 18, 2025 21:49
5ad199d to
529107a
Compare
mathemakitten
left a comment
Contributor
There was a problem hiding this comment.
This looks fine to me % a pass for docstrings and some comments on clarity for the new CudagraphArtifacts class.
mathemakitten
left a comment
Contributor
There was a problem hiding this comment.
This looks fine to me % a pass for docstrings and some comments on clarity for the new CudagraphArtifacts class.
deepakn94
reviewed
Dec 23, 2025
deepakn94
reviewed
Dec 23, 2025
jiemingz
force-pushed
the
jiemingz/mcore_cudagraph_improvements
branch
3 times, most recently
from
December 31, 2025 18:01
6a4c169 to
cb1eff2
Compare
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Signed-off-by: Jieming Zhang <jiemingz@nvidia.com>
Signed-off-by: Jieming Zhang <jiemingz@nvidia.com>
Signed-off-by: Jieming Zhang <jiemingz@nvidia.com>
Signed-off-by: Jieming Zhang <jiemingz@nvidia.com>
Signed-off-by: Jieming Zhang <jiemingz@nvidia.com>
Signed-off-by: Jieming Zhang <jiemingz@nvidia.com>
Signed-off-by: Jieming Zhang <jiemingz@nvidia.com>
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Signed-off-by: Jieming Zhang <jiemingz@nvidia.com>
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Co-authored-by: Robin Zhang <robinz@nvidia.com>
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
rogerwaleffe
approved these changes
Jan 16, 2026
sidsingh-nvidia
approved these changes
Jan 17, 2026
Contributor
Author
|
/ok to test 2e47f7d |
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Contributor
Author
|
/ok to test 976f167 |
ericharper
approved these changes
Jan 21, 2026
Contributor
|
/ok to test 5d0fc62 |
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Contributor
Author
|
/ok to test c26636e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.