[Community][Main] fix(moe): Fix theoretical memory calculation of layernorm. - #2434
Merged
Conversation
The calculation of parameters for `q_norm` and `kv_norm` should be multiplied by 2.
Treat different norm size for RMSNorm and LayerNorm
Contributor
|
/ok to test b3a845a |
Contributor
|
Thank you for your contribution! NVIDIA Megatron-LM is currently transitioning to development on Github. We will aim to review your PR after we complete our transition and stabilize our Github development process. Thank you for your understanding. |
yuzhongw-nvidia
changed the title
yuzhongw-nvidia
approved these changes
Dec 11, 2025
yuzhongw-nvidia
left a comment
yuzhongw-nvidia
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for your work.
daiyaanarfeen
pushed a commit
to daiyaanarfeen/Megatron-LM
that referenced
this pull request
Feb 23, 2026
…ernorm. (NVIDIA#2434) Co-authored-by: Yuzhong Wang <yuzhongw@nvidia.com>
yangbofun
pushed a commit
to xlm-research/Megatron-LM
that referenced
this pull request
May 22, 2026
…ernorm. (NVIDIA#2434) Co-authored-by: Yuzhong Wang <yuzhongw@nvidia.com>
terminator123
pushed a commit
to 021ai/Megatron-LM
that referenced
this pull request
Aug 3, 2026
…ernorm. (NVIDIA#2434) Co-authored-by: Yuzhong Wang <yuzhongw@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The calculation of parameters for
q_normandkv_normshould be multiplied by 2 for LayerNorm (includes both weight and bias) but by 1 for RMSNorm (only weight).