Skip to content

[training migration] Add LoggerConfig dataclass - #2414

Merged
maanug-nv merged 2 commits into
NVIDIA:mainfrom
maanug-nv:maanug/logcfg-generated-args
Jan 26, 2026
Merged

[training migration] Add LoggerConfig dataclass#2414
maanug-nv merged 2 commits into
NVIDIA:mainfrom
maanug-nv:maanug/logcfg-generated-args

Conversation

@maanug-nv

Copy link
Copy Markdown
Contributor

What does this PR do ?

  1. Create dataclass in MLM
  2. Get MLM arguments to use dataclass

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share discuss a design-doc with the team.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@copy-pr-bot

copy-pr-bot Bot commented Nov 26, 2025

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@maanug-nv maanug-nv mentioned this pull request Nov 26, 2025
100 tasks
Comment thread megatron/training/argument_utils.py
@Phlip79 Phlip79 linked an issue Dec 1, 2025 that may be closed by this pull request
100 tasks
@maanug-nv
maanug-nv force-pushed the maanug/logcfg-generated-args branch from 42af374 to 5f61d01 Compare January 12, 2026 23:48
@maanug-nv
maanug-nv marked this pull request as ready for review January 12, 2026 23:49
@ko3n1g
ko3n1g requested a review from a team January 12, 2026 23:50
@ko3n1g ko3n1g added this to the Core 0.16 milestone Jan 12, 2026
@maanug-nv maanug-nv self-assigned this Jan 13, 2026
@maanug-nv maanug-nv added enhancement New feature or request module: training Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. complexity: low Oncall Review labels Jan 13, 2026
help='Set default logging level')
from megatron.training.training_config import LoggerConfig

log_factory = ArgumentGroupFactory(LoggerConfig, exclude = ["log_throughput_to_tensorboard", "throughput_window_size", "memory_keys", "log_l2_norm_grad_to_tensorboard", "log_runtime_to_tensorboard", "runtime_time_unit", "filter_warnings", "modules_to_filter", "set_level_for_all_loggers", "save_config_filepath"])

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several of these excluded settings are for metrics currently logged in Megatron Bridge but not in MegatronLM. I think we will eventually like to upstream logging of those metrics to MegatronLM.
cc @dimapihtar

Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>

@Wohox Wohox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Comment thread megatron/training/arguments.py
@maanug-nv
maanug-nv added this pull request to the merge queue Jan 24, 2026
github-merge-queue Bot pushed a commit that referenced this pull request Jan 24, 2026
Signed-off-by: Maanu Grover <maanug@nvidia.com>
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 24, 2026
@maanug-nv
maanug-nv added this pull request to the merge queue Jan 26, 2026
Merged via the queue into NVIDIA:main with commit 497d42d Jan 26, 2026
55 checks passed
@maanug-nv
maanug-nv deleted the maanug/logcfg-generated-args branch January 26, 2026 05:51
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
Signed-off-by: Maanu Grover <maanug@nvidia.com>
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
Signed-off-by: Maanu Grover <maanug@nvidia.com>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: low enhancement New feature or request Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. module: training

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dataclass Migration Effort

6 participants