[training migration] Add LoggerConfig dataclass - #2414
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
100 tasks
Skylion007
reviewed
Nov 28, 2025
100 tasks
maanug-nv
force-pushed
the
maanug/logcfg-generated-args
branch
from
January 12, 2026 23:48
42af374 to
5f61d01
Compare
maanug-nv
marked this pull request as ready for review
January 12, 2026 23:49
maanug-nv
commented
Jan 13, 2026
| help='Set default logging level') | ||
| from megatron.training.training_config import LoggerConfig | ||
|
|
||
| log_factory = ArgumentGroupFactory(LoggerConfig, exclude = ["log_throughput_to_tensorboard", "throughput_window_size", "memory_keys", "log_l2_norm_grad_to_tensorboard", "log_runtime_to_tensorboard", "runtime_time_unit", "filter_warnings", "modules_to_filter", "set_level_for_all_loggers", "save_config_filepath"]) |
Contributor
Author
There was a problem hiding this comment.
Several of these excluded settings are for metrics currently logged in Megatron Bridge but not in MegatronLM. I think we will eventually like to upstream logging of those metrics to MegatronLM.
cc @dimapihtar
lmcafee-nvidia
approved these changes
Jan 22, 2026
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
maanug-nv
force-pushed
the
maanug/logcfg-generated-args
branch
from
January 23, 2026 01:43
5f61d01 to
8bef23f
Compare
Wohox
reviewed
Jan 23, 2026
jaredcasper
approved these changes
Jan 24, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 24, 2026
Signed-off-by: Maanu Grover <maanug@nvidia.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jan 24, 2026
daiyaanarfeen
pushed a commit
to daiyaanarfeen/Megatron-LM
that referenced
this pull request
Feb 23, 2026
Signed-off-by: Maanu Grover <maanug@nvidia.com>
yangbofun
pushed a commit
to xlm-research/Megatron-LM
that referenced
this pull request
May 22, 2026
Signed-off-by: Maanu Grover <maanug@nvidia.com>
terminator123
pushed a commit
to 021ai/Megatron-LM
that referenced
this pull request
Aug 3, 2026
Signed-off-by: Maanu Grover <maanug@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.