Skip to content

[DEV] Update emerging optimizers #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FDecaYed merged 3 commits into from
Nov 18, 2025
+34 −209
Merged

[DEV] Update emerging optimizers #2261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dad4a3c
update emerging-optimizer to v0.1.0
skyw Nov 14, 2025
4e326f1
update uv lock
skyw Nov 15, 2025
e2bb6c3
add setuptools back for dev
skyw Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions megatron/core/optimizer/muon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,15 +95,16 @@ def scaled_orthogonalize_fn(
self.is_qkv_fn = is_qkv_fn
self.qkv_split_shapes = qkv_split_shapes

weight_decay_method = "decoupled" if use_decoupled_weight_decay else "l2"
super().__init__(
params,
lr,
momentum_beta,
use_nesterov,
weight_decay,
use_decoupled_weight_decay,
fp32_matmul_prec,
scaled_orthogonalize_fn,
use_nesterov=use_nesterov,
weight_decay=weight_decay,
weight_decay_method=weight_decay_method,
fp32_matmul_prec=fp32_matmul_prec,
scaled_orthogonalize_fn=scaled_orthogonalize_fn,
)

def orthogonalize(self, p: torch.Tensor, grad: torch.Tensor, **kwargs: Any) -> torch.Tensor:
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Copyright (c) 2023, NVIDIA CORPORATION. All rights reserved.

[build-system]
requires = ["setuptools>=80.0.0", "pybind11", "packaging>=24.2"]
requires = ["setuptools<80.0.0", "pybind11", "packaging>=24.2"]
build-backend = "setuptools.build_meta"

[tool.setuptools]
Expand Down Expand Up @@ -170,7 +170,7 @@ flash_mla = [
]
transformer-engine = { git = "https://github.com/NVIDIA/TransformerEngine.git", rev = "release_v2.9" } # on `release_v2.9`
nemo-run = { git = "https://github.com/NVIDIA-NeMo/Run.git", rev = "01a9a8ba360f7b2908728ad0516e0ad9d936966d" }
emerging_optimizers = { git = "https://github.com/NVIDIA-NeMo/Emerging-Optimizers.git", rev = "cf9909b777ffac18e05b67a6708282cadc000942" }
emerging_optimizers = { git = "https://github.com/NVIDIA-NeMo/Emerging-Optimizers.git", rev = "v0.1.0" }

[tool.isort]
profile = "black" # black-compatible
Expand Down
Loading
Loading