Skip to content

Add muon and layerwise distributed optimizer - #2241

Merged
Phlip79 merged 29 commits into
NVIDIA:mainfrom
FDecaYed:deyuf/muon
Jan 14, 2026
Merged

Add muon and layerwise distributed optimizer#2241
Phlip79 merged 29 commits into
NVIDIA:mainfrom
FDecaYed:deyuf/muon

Conversation

@FDecaYed

Copy link
Copy Markdown
Contributor

What does this PR do ?

Add muon and layerwise distributed optimizer to maim

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

FDecaYed and others added 7 commits November 13, 2025 21:10
…imizer

Co-authored-by: Zijie Yan <zijiey@nvidia.com>
Co-authored-by: Hao Wu <skyw@nvidia.com>
Co-authored-by: oliver könig <okoenig@nvidia.com>
Co-authored-by: Boxiang Wang <boxiangw@nvidia.com>
Co-authored-by: mikail <mkhona@nvidia.com>
…t format (NVIDIA#1928)

Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
Co-authored-by: Deyu Fu <Deyu.Foo@gmail.com>
…ayerwise distopt (NVIDIA#1965)

Signed-off-by: Deyu Fu <deyuf@nvidia.com>
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
@FDecaYed
FDecaYed requested review from a team as code owners November 13, 2025 13:32
@copy-pr-bot

copy-pr-bot Bot commented Nov 13, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

skyw added 3 commits November 18, 2025 14:07
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
@FDecaYed FDecaYed mentioned this pull request Nov 18, 2025
6 tasks
@JavaZeroo

Copy link
Copy Markdown
Contributor

is there any example shell for muon optimizer?

@BoxiangW
BoxiangW self-requested a review December 3, 2025 19:29
@BoxiangW

BoxiangW commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

@JavaZeroo simply set --optimizer dist_muon(Layerwise distributed optimizer) or --optimizer muon will turn on Muon usage

Comment thread megatron/core/optimizer/optimizer_config.py
@Phlip79

Phlip79 commented Jan 14, 2026

Copy link
Copy Markdown
Member

/ok to test 3dd2f5c

@Phlip79

Phlip79 commented Jan 14, 2026

Copy link
Copy Markdown
Member

/ok to test 98189ec

@Phlip79

Phlip79 commented Jan 14, 2026

Copy link
Copy Markdown
Member

/ok to test 4dafbfa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: high dev2main: mbridge dev to main: this PR is needed in main for mbridge Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. Final Review PR is in the "final review" stage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants