[MoE] Improvement of shared expert overlap, support shared expert overlap for FlexDispatcher - #2207
Merged
yaox12 merged 9 commits intoApr 14, 2026
Conversation
Contributor
|
@fanshiqing can you please take a look at this MR? |
Skylion007
reviewed
Nov 11, 2025
Contributor
|
/ok to test 3e308ac |
Author
|
/ok to test 6d8961a |
Author
|
/ok to test c811dde |
kvareddy
approved these changes
Apr 13, 2026
ericharper
approved these changes
Apr 13, 2026
Author
|
/ok to test 5019ff9 |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24347395503 |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 13, 2026
…eplay During scoped CUDA graph replay (moe_preprocess in scope), dispatch_preprocess is skipped (decorator returns from tensor store), so self.probs and self.routing_map are never re-set. The cleanup added in combine_postprocess sets them to None, causing combine_preprocess to crash on self.probs.dtype access. These tensors are small (O(tokens * experts)) and overwritten on the next dispatch_preprocess call, so the cleanup is unnecessary. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
|
/ok to test c4e53e9 |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24391557545 |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24393098522 |
yangbofun
pushed a commit
to xlm-research/Megatron-LM
that referenced
this pull request
May 22, 2026
…rlap for FlexDispatcher (NVIDIA#2207) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yhgalaxy
pushed a commit
to yhgalaxy/Megatron-LM
that referenced
this pull request
Jun 17, 2026
…rlap for FlexDispatcher (NVIDIA#2207) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Design doc: https://docs.google.com/document/d/1whtnUiw1hpfdkjFss_g5P8fyIT9xBA5XJvmdklFes48/edit?usp=sharing
Changelog:
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.