Skip to content

Add MoE parameters to ModelOpt pruning example + conf fixes - #2205

Merged
ko3n1g merged 1 commit into
NVIDIA:mainfrom
kevalmorabia97:kmorabia/pruning-moe
Nov 11, 2025
Merged

Add MoE parameters to ModelOpt pruning example + conf fixes#2205
ko3n1g merged 1 commit into
NVIDIA:mainfrom
kevalmorabia97:kmorabia/pruning-moe

Conversation

@kevalmorabia97

@kevalmorabia97 kevalmorabia97 commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

What does this PR do ?

  • ModelOpt Pruning example update: enable MoE parameters, ability to reuse pruning scores for pruning to different configs, print pruned model params, update readme support matrix
  • Change conf/qwen to conf/Qwen while maintaining symlink conf/qwen for bw compatibility
  • Add conf/NVIDIA-Nemotron-Nano-9B-v2-Base.sh symlink to conf/NVIDIA-Nemotron-Nano-9B-v2.sh

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share discuss a design-doc with the team.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@kevalmorabia97
kevalmorabia97 requested review from a team, AAnoosheh and ChenhanYu November 11, 2025 08:01
@kevalmorabia97 kevalmorabia97 added the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Nov 11, 2025
@ko3n1g ko3n1g added this to the Core 0.16 milestone Nov 11, 2025
@kevalmorabia97 kevalmorabia97 changed the title Add MoE parameters to ModelOpt pruning example Add MoE parameters to ModelOpt pruning example + conf fixes Nov 11, 2025
@kevalmorabia97 kevalmorabia97 added Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. and removed Final Review PR is in the "final review" stage labels Nov 11, 2025
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Final Review PR is in the "final review" stage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants