Skip to content

Remove calculation of padding token in moe routing loss - #2142

Merged
HaochenYuan merged 30 commits into
NVIDIA:mainfrom
HaochenYuan:main
Jan 23, 2026
Merged

Remove calculation of padding token in moe routing loss#2142
HaochenYuan merged 30 commits into
NVIDIA:mainfrom
HaochenYuan:main

Conversation

@HaochenYuan

@HaochenYuan HaochenYuan commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

What does this PR do ?

Related issue: #1984
This PR removes the calculation of padding token in aux loss.
See detailed description in corresponding dev branch PR #2754

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share discuss a design-doc with the team.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@HaochenYuan
HaochenYuan requested review from a team as code owners November 5, 2025 14:53
@copy-pr-bot

copy-pr-bot Bot commented Nov 5, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yaox12 yaox12 added the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Nov 6, 2025
@HaochenYuan
HaochenYuan requested review from a team as code owners November 13, 2025 15:35
@HaochenYuan

Copy link
Copy Markdown
Contributor Author

/ok to test ccee48d

@Victarry Victarry left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Already reviewed the PR to the dev branch.

@HaochenYuan

Copy link
Copy Markdown
Contributor Author

/ok to test 767638c

@duncanriach duncanriach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Phlip79

Phlip79 commented Jan 21, 2026

Copy link
Copy Markdown
Member

/ok to test 2525c62

@Phlip79

Phlip79 commented Jan 21, 2026

Copy link
Copy Markdown
Member

Accidentally closed this PR, sorry about that.

@Phlip79

Phlip79 commented Jan 21, 2026

Copy link
Copy Markdown
Member

@HaochenYuan can you please take a look at failing test?

@HaochenYuan

Copy link
Copy Markdown
Contributor Author

@HaochenYuan can you please take a look at failing test?

I'm working on it. There seems to do something wrong with the ci machine.

9-task-1-0/0 [default0]:[2026-01-22 09:20:41] mcore-ci-test-1769073559-task-1-0:273:1483 [0] misc/shmutils.cc:87 NCCL WARN Error: failed to extend /dev/shm/nccl-SAQVeM to 34210180 bytes, error: No space left on device (28)
9-task-1-0/0 [default0]:
9-task-1-0/0 [default0]:[2026-01-22 09:20:41] mcore-ci-test-1769073559-task-1-0:273:1483 [0] misc/shmutils.cc:131 NCCL WARN Error while creating shared memory segment /dev/shm/nccl-SAQVeM (size 34210176), error: No space left on device (28)
9-task-1-0/0 [default0]:mcore-ci-test-1769073559-task-1-0:273:1483 [0] NCCL INFO proxy.cc:1374 -> 2
9-task-1-0/0 [default0]:mcore-ci-test-1769073559-task-1-0:273:1483 [0] NCCL INFO proxy.cc:1440 -> 2
9-task-1-0/0 [default0]:
9-task-1-0/0 [default0]:[2026-01-22 09:20:41] mcore-ci-test-1769073559-task-1-0:273:1483 [0] misc/shmutils.cc:87 NCCL WARN Error: failed to extend /dev/shm/nccl-LVYUle to 34210180 bytes, error: No space left on device (28)
9-task-1-0/0 [default0]:
9-task-1-0/0 [default0]:[2026-01-22 09:20:41] mcore-ci-test-1769073559-task-1-0:273:1483 [0] misc/shmutils.cc:131 NCCL WARN Error while creating shared memory segment /dev/shm/nccl-LVYUle (size 34210176), error: No space left on device (28)

@HaochenYuan

Copy link
Copy Markdown
Contributor Author

@HaochenYuan can you please take a look at failing test?

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: high dev2main: mbridge dev to main: this PR is needed in main for mbridge Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. Final Review PR is in the "final review" stage module: moe

Projects

None yet

Development

Successfully merging this pull request may close these issues.