Skip to content

[DEV] Make CUDA graph compatible with FP8 params (tensorwise & blockwise). - #2087

Merged
yaox12 merged 9 commits into
NVIDIA:devfrom
kunlunl:kunlunl/fp8_param_cuda_graph_support
Nov 12, 2025
Merged

[DEV] Make CUDA graph compatible with FP8 params (tensorwise & blockwise).#2087
yaox12 merged 9 commits into
NVIDIA:devfrom
kunlunl:kunlunl/fp8_param_cuda_graph_support

Conversation

@kunlunl

@kunlunl kunlunl commented Nov 2, 2025

Copy link
Copy Markdown
Contributor

What does this PR do ?

Corresponding MR in main branch: #2088

Depend on the TE MR:

Make CUDA graph compatible with FP8 params (tensorwise & blockwise).

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@kunlunl
kunlunl requested review from a team as code owners November 2, 2025 11:25
@copy-pr-bot

copy-pr-bot Bot commented Nov 2, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@kunlunl kunlunl changed the title Kunlunl/fp8 param cuda graph support [dev] fp8 param cuda graph support Nov 2, 2025
@kunlunl kunlunl mentioned this pull request Nov 2, 2025
6 tasks
@yaox12 yaox12 added the bug Something isn't working label Nov 3, 2025
Comment thread tests/unit_tests/test_fp8_param.py Outdated
@yaox12

yaox12 commented Nov 3, 2025

Copy link
Copy Markdown
Member

/ok to test ad04e9f

@ko3n1g ko3n1g added this to the Core 0.16 milestone Nov 3, 2025
@yanring yanring changed the title [dev] fp8 param cuda graph support [DEV] Make CUDA graph compatible with FP8 params (tensorwise & blockwise). Nov 10, 2025
@yaox12

yaox12 commented Nov 10, 2025

Copy link
Copy Markdown
Member

/ok to test 09f0823

@yaox12 yaox12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yaox12

yaox12 commented Nov 12, 2025

Copy link
Copy Markdown
Member

/ok to test 099a5ba

@yaox12

yaox12 commented Nov 12, 2025

Copy link
Copy Markdown
Member

Internal functional tests all passed.

Signed-off-by: kunlunl <kunlunl@nvidia.com>
@kunlunl

kunlunl commented Nov 12, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test 63fd275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dev branch Dev branch related issues and development module: moe

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants