Skip to content

Add DeepSeek-V3 GB200 NVL72 optimization guide - #2059

Merged
yaox12 merged 4 commits into
NVIDIA:devfrom
sbhavani:add-deepseek-guide-clean
Oct 31, 2025
Merged

Add DeepSeek-V3 GB200 NVL72 optimization guide#2059
yaox12 merged 4 commits into
NVIDIA:devfrom
sbhavani:add-deepseek-guide-clean

Conversation

@sbhavani

Copy link
Copy Markdown
Contributor

What does this PR do ?

Description

This PR creates a new docs/discussions/ directory for in-depth guides and adds a comprehensive optimization guide for DeepSeek-V3 training on GB200 NVL72.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share discuss a design-doc with the team.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests (N/A - documentation only)
  • I have added relevant functional tests (N/A - documentation only)
  • I have added proper typing to my code Typing guidelines (N/A - documentation only)
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR (N/A - documentation only)

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

- Add discussions directory with index README
@sbhavani sbhavani added the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Oct 31, 2025
@sbhavani
sbhavani requested a review from a team as a code owner October 31, 2025 05:05
@sbhavani sbhavani added the docs-only documentation only (docs or docstrings) label Oct 31, 2025
@sbhavani
sbhavani requested a review from a team as a code owner October 31, 2025 05:05
@ko3n1g ko3n1g added this to the Core 0.16 milestone Oct 31, 2025
@sbhavani

Copy link
Copy Markdown
Contributor Author

@yanring

@yaox12 yaox12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We have done many rounds of review.

@yaox12
yaox12 added this pull request to the merge queue Oct 31, 2025
Merged via the queue into NVIDIA:dev with commit 402bc50 Oct 31, 2025
25 checks passed
@sbhavani
sbhavani deleted the add-deepseek-guide-clean branch November 6, 2025 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-only documentation only (docs or docstrings) Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants