Skip to content

[Dev] Fix Qwen3-Next hang on Blackwell, add a flag to control torch.compile - #2058

Merged
BestJuly merged 3 commits into
NVIDIA:devfrom
yuzhongw-nvidia:fix_qwen3next_blackwell
Nov 6, 2025
Merged

[Dev] Fix Qwen3-Next hang on Blackwell, add a flag to control torch.compile #2058
BestJuly merged 3 commits into
NVIDIA:devfrom
yuzhongw-nvidia:fix_qwen3next_blackwell

Conversation

@yuzhongw-nvidia

@yuzhongw-nvidia yuzhongw-nvidia commented Oct 31, 2025

Copy link
Copy Markdown
Contributor

What does this PR do ?

torch.compile is not very well supported on Blackwell, and may cause Qwen3-Next hanging when training on Blackwell. Add a flag in arguments to disable it.

With triton>=3.4.0, this fix PR, and the following extra arguments, the issue will be well resolved.

  --disable-jit-fuser \
  --no-bias-gelu-fusion \
  --no-bias-swiglu-fusion \
  --no-bias-dropout-fusion

MR to main

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share discuss a design-doc with the team.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@yuzhongw-nvidia
yuzhongw-nvidia requested review from a team as code owners October 31, 2025 04:06
@copy-pr-bot

copy-pr-bot Bot commented Oct 31, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yuzhongw-nvidia
yuzhongw-nvidia changed the base branch from main to dev October 31, 2025 04:08
@yuzhongw-nvidia
yuzhongw-nvidia removed request for a team October 31, 2025 04:08
@yuzhongw-nvidia

Copy link
Copy Markdown
Contributor Author

/ok to test 9a2ce88

@yuzhongw-nvidia

Copy link
Copy Markdown
Contributor Author

/ok to test 6a68816

@yuzhongw-nvidia
yuzhongw-nvidia force-pushed the fix_qwen3next_blackwell branch from 6a68816 to 158e53b Compare October 31, 2025 04:17
@yuzhongw-nvidia

Copy link
Copy Markdown
Contributor Author

/ok to test 158e53b

@yanring yanring changed the title Fix Qwen3-Next hang on Blackwell, add a flag to control torch.compile [Dev] Fix Qwen3-Next hang on Blackwell, add a flag to control torch.compile Nov 5, 2025
@yanring

yanring commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

LGTM

@yanring
yanring requested a review from BestJuly November 5, 2025 07:42
@NVIDIA NVIDIA deleted a comment from copy-pr-bot Bot Nov 5, 2025
@yuzhongw-nvidia

Copy link
Copy Markdown
Contributor Author

/ok to test 327c2b2

@yuzhongw-nvidia
yuzhongw-nvidia force-pushed the fix_qwen3next_blackwell branch from 327c2b2 to 4c3dd9e Compare November 5, 2025 08:52
@yuzhongw-nvidia

Copy link
Copy Markdown
Contributor Author

/ok to test 4c3dd9e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants