Skip to content

chore: Update tooling for interactive jobs #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ko3n1g merged 3 commits into from
Oct 29, 2025
Merged

chore: Update tooling for interactive jobs #2032

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d8ca51
chore: Update tooling for interactive jobs
ko3n1g Oct 29, 2025
4515cea
default
ko3n1g Oct 29, 2025
0980c79
copyright
ko3n1g Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/functional_tests/shell_test_utils/start_interactive_job.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ DATASET_DIR=""
TIME="1:00:00"
RECIPES_DIR="tests/test_utils/recipes"
CONTAINER_MOUNTS=""
NO_GPUS_PER_TASK="FALSE"

# Declare associative array for tracking unique mounts
declare -A seen_mounts
Expand Down Expand Up @@ -53,6 +54,10 @@ while [[ $# -gt 0 ]]; do
TIME="$2"
shift 2
;;
--no-gpus-per-task)
NO_GPUS_PER_TASK="TRUE"
shift 1
;;
--help)
print_usage
exit 0
Expand Down Expand Up @@ -89,7 +94,7 @@ SRUN_CMD="srun \
--container-workdir=/opt/megatron-lm \
--container-mounts=$CONTAINER_MOUNTS \
--nodes=1 \
--gpus-per-task=8 \
$(if [ "$NO_GPUS_PER_TASK" = "FALSE" ]; then echo "--gpus-per-task=8"; fi) \
--time=$TIME \
--pty bash"

Expand Down
2 changes: 0 additions & 2 deletions tests/test_utils/python_scripts/generate_local_jobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,6 @@ def main(
container_tag="none",
)

print(workloads)

for workload in workloads:
if workload.type == "build":
continue
Expand Down
Loading