Skip to content

wandb Inference stats logging - #2026

Merged
wdykas merged 6 commits into
NVIDIA:mainfrom
wdykas:inference-logging
Nov 5, 2025
Merged

wandb Inference stats logging#2026
wdykas merged 6 commits into
NVIDIA:mainfrom
wdykas:inference-logging

Conversation

@wdykas

@wdykas wdykas commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

What does this PR do ?

This adds the ability to log different stats of the dynamic inference engine for debugging and optimization. This is particularly useful for the RL case to make sure the engine is properly oversubscribed.

We may need to change the stats with new UVM oversubscription methods we are implementing.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@wdykas
wdykas requested review from a team as code owners October 29, 2025 15:36
@copy-pr-bot

copy-pr-bot Bot commented Oct 29, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@wdykas
wdykas requested a review from a team as a code owner October 29, 2025 16:47
@sidsingh-nvidia

Copy link
Copy Markdown
Contributor

LGTM.
I'm a bit worried about the unit test - does it rely on a stable internet connection to the wandb servers? We have seen tests fail in the past due to huggingface rate limits. Maybe set WANDB_MODE=offline as a precaution?

@wdykas

wdykas commented Oct 31, 2025

Copy link
Copy Markdown
Contributor Author

LGTM. I'm a bit worried about the unit test - does it rely on a stable internet connection to the wandb servers? We have seen tests fail in the past due to huggingface rate limits. Maybe set WANDB_MODE=offline as a precaution?

hmm intersting I dont think this unit test will use actual wandb? I thought I had it setup to be all mocked

@wdykas

wdykas commented Oct 31, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test 04c8549

@wdykas
wdykas requested a review from a team as a code owner October 31, 2025 19:13
@wdykas

wdykas commented Oct 31, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test f206dc9

@wdykas
wdykas added this pull request to the merge queue Nov 5, 2025
Merged via the queue into NVIDIA:main with commit 26b2eb5 Nov 5, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants