Repository navigation
Async task and event loop safety in Megatron Core #2025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
ccd518c
Wrap all `create_task` in `trace_async_exceptions`
tdene daa3852
Ensure the correct loop is being reused
tdene e6bffd7
lint W0141
tdene 89bd498
imports
tdene 8de311d
Fix usage of `print` in core/utils.py
ArEsKay3 8970699
Merge remote-tracking branch 'gh/main' into tde/async_safety
tdene a4863b5
Fix typo
tdene 7bc898f
Merge branch 'main' into tde/async_safety
tdene 67fabaf
Merge branch 'main' into tde/async_safety
tdene f8709df
Merge branch 'main' into tde/async_safety
tdene 2df5cd6
Merge remote-tracking branch 'gh/main' into tde/async_safety
tdene a7fd852
Merge branch 'main' into tde/async_safety
tdene cd4e98a
Merge branch 'main' into tde/async_safety
tdene a8d88cf
Merge branch 'main' into tde/async_safety
tdene 9684cc9
Merge branch 'main' into tde/async_safety
tdene fe1a1af
Merge branch 'main' into tde/async_safety
tdene d46b20e
Merge branch 'main' into tde/async_safety
tdene da979ab
Merge branch 'main' into tde/async_safety
tdene 8500998
Merge remote-tracking branch 'gh/main' into tde/async_safety
tdene ea5c07f
Guard against process initialization failure
tdene 8b25187
Guard against loop confusion in task creation
tdene 9bf8f21
Overwrite OneLogger logging config in coordinator
tdene 63eaa7b
Register faulthandler for coordinator subprocess
tdene aeb4859
Guard against users via trace_async_exceptions
tdene c73a802
lint
tdene 8f5772b
Revert "Guard against users via trace_async_exceptions"
tdene 230e26e
Make future creation safe
tdene File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.